Skip to content
This repository has been archived by the owner on Oct 13, 2024. It is now read-only.

feat(yt-dl): automatically gather youtube cookies #227

Conversation

ReenigneArcher
Copy link
Member

Description

This PR adds the ability to automatically consent and collect cookies from YouTube.com.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

Copy link

codecov bot commented Nov 20, 2023

Codecov Report

Attention: Patch coverage is 35.78431% with 131 lines in your changes are missing coverage. Please review.

Project coverage is 64.05%. Comparing base (94e5193) to head (3094554).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #227      +/-   ##
==========================================
- Coverage   69.84%   64.05%   -5.80%     
==========================================
  Files          12       14       +2     
  Lines         985     1185     +200     
==========================================
+ Hits          688      759      +71     
- Misses        297      426     +129     
Flag Coverage Δ
Linux 63.79% <34.31%> (-6.06%) ⬇️
Windows 63.71% <34.80%> (-5.94%) ⬇️
macOS 63.62% <34.31%> (-6.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
Contents/Code/scheduled_tasks.py 94.73% <100.00%> (+0.29%) ⬆️
Contents/Code/general_helper.py 91.30% <88.23%> (-1.01%) ⬇️
Contents/Code/youtube_dl_helper.py 74.66% <60.00%> (+0.34%) ⬆️
Contents/Code/platform_helper.py 60.00% <60.00%> (ø)
Contents/Code/selenium_helper.py 24.51% <24.51%> (ø)

@ReenigneArcher ReenigneArcher force-pushed the feat(yt-dl)-automatically-gather-youtube-cookies branch from ef80399 to 6095e17 Compare November 20, 2023 02:04
@ReenigneArcher
Copy link
Member Author

We might be able to use selenium manager to handle driver updates. https://www.selenium.dev/documentation/selenium_manager/

@ReenigneArcher

This comment was marked as resolved.

@ReenigneArcher ReenigneArcher force-pushed the feat(yt-dl)-automatically-gather-youtube-cookies branch 8 times, most recently from e8d18ed to 2860a90 Compare November 22, 2023 03:46
@ReenigneArcher ReenigneArcher force-pushed the feat(yt-dl)-automatically-gather-youtube-cookies branch 9 times, most recently from dd0822b to 6021092 Compare November 29, 2023 03:41

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@ReenigneArcher ReenigneArcher force-pushed the feat(yt-dl)-automatically-gather-youtube-cookies branch from 6021092 to 3094554 Compare January 20, 2024 22:52
@ReenigneArcher
Copy link
Member Author

@zdimension do you think this feature is worth continuing?

@zdimension
Copy link
Collaborator

@zdimension do you think this feature is worth continuing?

Honestly, I think it will only get more difficult in the future to log in to YT in an automated fashion, like we're doing here, so I'm not sure it's worth the hassle. I mean, I've put my YT cookies in the Themerr settings a month or two ago and since then it's been working flawlessly (except for region locked content, but we're not getting past that anyway unless we use a proxy or VPN). So manually filling in the cookies doesn't seem to be that much of a problem, to me.

@ReenigneArcher
Copy link
Member Author

Alright, there were other cleanups in here. I'll pull those out into a separate PR.

And I think there's an option in youtube-dl to use a proxy. That should probably be added as a config option for both youtube-dl and accessing ThemerrDB/GitHub.

@ReenigneArcher ReenigneArcher deleted the feat(yt-dl)-automatically-gather-youtube-cookies branch July 15, 2024 23:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants