Tidy up code.

Remove missing proto as an error.
Longi94 · Jul 31, 2024 · 5a4592c · 5a4592c
1 parent 1aa5e4a
commit 5a4592c
Showing 1 changed file with 26 additions and 22 deletions.
diff --git a/...java/in/dragonbra/javasteam/steam/handlers/steamunifiedmessages/SteamUnifiedMessages.java b/...java/in/dragonbra/javasteam/steam/handlers/steamunifiedmessages/SteamUnifiedMessages.java
@@ -119,36 +119,40 @@ private void handleServiceMethod(IPacketMsg packetMsg) {
         PacketClientMsgProtobuf packetMsgProto = (PacketClientMsgProtobuf) packetMsg;
 
         String jobName = packetMsgProto.getHeader().getProto().getTargetJobName();
-        if (!Strings.isNullOrEmpty(jobName)) {
-            String[] splitByDot = jobName.split("\\.");
-            String[] splitByHash = splitByDot[1].split("#");
 
-            String serviceName = splitByDot[0];
-            String methodName = splitByHash[0];
+        if (Strings.isNullOrEmpty(jobName)) {
+            logger.debug("Job name is null or empty");
+            return;
+        }
 
-            String serviceInterfaceName = "in.dragonbra.javasteam.rpc.interfaces.I" + serviceName;
-            try {
-                logger.debug("Handling Service Method: " + serviceInterfaceName);
+        String[] splitByDot = jobName.split("\\.");
+        String[] splitByHash = splitByDot[1].split("#");
 
-                Class<?> serviceInterfaceType = Class.forName(serviceInterfaceName);
+        String serviceName = splitByDot[0];
+        String methodName = splitByHash[0];
 
-                Method method = null;
-                for (Method m : serviceInterfaceType.getDeclaredMethods()) {
-                    if (m.getName().equals(methodName)) {
-                        method = m;
-                    }
-                }
+        String serviceInterfaceName = "in.dragonbra.javasteam.rpc.interfaces.I" + serviceName;
+        try {
+            logger.debug("Handling Service Method: " + serviceInterfaceName);
 
-                if (method != null) {
-                    Class<? extends AbstractMessage> argumentType = (Class<? extends AbstractMessage>) method.getParameterTypes()[0];
+            Class<?> serviceInterfaceType = Class.forName(serviceInterfaceName);
 
-                    client.postCallback(new ServiceMethodNotification(argumentType, packetMsg));
+            Method method = null;
+            for (Method m : serviceInterfaceType.getDeclaredMethods()) {
+                if (m.getName().equals(methodName)) {
+                    method = m;
                 }
-            } catch (ClassNotFoundException e) {
-                // The RPC service implementation was not implemented.
-                // Either the .proto is missing, or the service was not converted to an interface yet.
-                logger.error("Service Method: " + serviceName + ", was not found");
             }
+
+            if (method != null) {
+                Class<? extends AbstractMessage> argumentType = (Class<? extends AbstractMessage>) method.getParameterTypes()[0];
+
+                client.postCallback(new ServiceMethodNotification(argumentType, packetMsg));
+            }
+        } catch (ClassNotFoundException e) {
+            // The RPC service implementation was not implemented.
+            // Either the .proto is missing, or the service was not converted to an interface yet.
+            logger.debug("Service Method: " + serviceName + ", was not found");
         }
     }
 }