Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify callback dispatching #269

Merged
merged 5 commits into from
Aug 15, 2024

Conversation

LossyDragon
Copy link
Collaborator

Description

(Large PR)

  • Migrate all handlers to kotlin, maintaining java compatibility.
  • Moves IPacketMsg to the callback constructors
  • Remove outdated tests as the new kt handlers check for NonNull parameters.
  • Remove useless null throws with the same reason above
  • Tweak samples for changes and error logging.
  • Add FriendCache class in SteamFriends
  • Add misc missing documentation and variables that SK may have had.

Checks off "PR 1390" in #181

Checklist

  • Code compiles correctly
  • All tests passing
  • Samples run successfully
  • Extended the README / documentation, if necessary

Simplify callback dispatching.
Remove outdated tests as we now check for NonNull parameters.
Tweak samples for changes and error logging.
Add more friend helper methods.
Fix some method overloads.
@LossyDragon LossyDragon merged commit 8f781d1 into Longi94:master Aug 15, 2024
1 check passed
@LossyDragon LossyDragon deleted the simplify-callbacks2 branch August 15, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant