style: Add black linter options and line length set to 100 #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruff parameters can be included in toml file
…ne-lengths-to-100' of https://github.com/Loop3D/map2loop into 34-style-add-pyprojecttoml-for-black-linting-and-set-line-lengths-to-100
was calling isinstance incorrectly, but it makes more sense to use subclass. Although beartype won't let that.
There was a problem hiding this comment.
@RoyThomsonMonash I've added enough changes to this that you should also review it!
.flake8
Outdated
There was a problem hiding this comment.
@RoyThomsonMonash I've changed the CI to use ruff which can be specified in the toml file, should we delete this file?
There was a problem hiding this comment.
Reviewed changes to use ruff instead of flake8 and noting use of isinstance or issubclass checks.
I'm happy to approve and merge but there are a lot of ignore codes for ruff linting, are ruff defaults not compatible with black?
Happy to delete .flake8 file as it isn't needed anymore.
RoyThomsonMonash
deleted the
34-style-add-pyprojecttoml-for-black-linting-and-set-line-lengths-to-100
branch
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.