Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update progressCell for bolus display #2263

Open
wants to merge 1 commit into
base: tidepool-merge
Choose a base branch
from

Conversation

marionbarker
Copy link
Contributor

Purpose:

This PR fixes an intermittent bolus progress display error reported in these issues

@itsmojo identified root cause for this intermittent display error and passed on a proposed fix for the main branch.

If a bolus progress is being displayed when the app is put into background and then the app is opened in the middle of a bolus, the progress bar shows a stale value of the expected total units; the stale value is the total units from the last time the bolus progress bar was displayed.

I tested the tidepool-merge build using this test method and showed the intermittent display error occurs with tidepool-merge as well as main. The fix from @itsmojo was modified to work with the new tidepool-merge version of the Loop/View Controllers/StatusTableViewController.swift file.

Test

This PR was applied to tidepool-merge. The same test method mentioned above was used and every instance of opening the app in the middle of a bolus showed the correct value for the total bolus units.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant