Skip to content

Commit

Permalink
More minor fixes
Browse files Browse the repository at this point in the history
+ Fixed .github yaml /issues links duplicated
+ Fixed .github yaml label has **title**
  (it was supposed to be bold title, but in new format
	its automatically in bold format, so its no longer needed).
+ [ErrorActivity] Fix crash log code format not working
	(had to add extra newline for it to work)
+ [SettingsActivity] Sort restore value type thingy.

Important message:
I'm now using git cli (with gh for auth), and git-cola
after GitHub desktop linux flatpak commit incident,
but that isn't going to help me to reinstate my account,
if this still happens for a month (which is likely
because according to people reports, and GitHub 2021
transparency reports, the staff didn't respond to
account reinstating requests),
i probably have to migrate to Codeberg
and make GitHub repo version essentially
a "mirror" of it.
  • Loading branch information
MDP43140 committed Mar 31, 2024
1 parent 3c10ab6 commit 43b121c
Show file tree
Hide file tree
Showing 4 changed files with 23 additions and 17 deletions.
26 changes: 16 additions & 10 deletions .github/ISSUE_TEMPLATE/bug-report.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ body:
options:
- label: "I am able to reproduce the bug with the latest version."
required: true
- label: "I made sure that there are *no existing issues* - [open](./issues) or [closed](./issues?q=is%3Aissue+is%3Aclosed) - which I could contribute my information to."
- label: "I made sure that there are *no existing issues* - [open](.) or [closed](.?q=is%3Aissue+is%3Aclosed) - which I could contribute my information to."
required: true
- label: "I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise."
required: true
Expand All @@ -34,16 +34,11 @@ body:
required: true

- type: textarea
id: expected-behavior
id: expected-and-actual-behavior
attributes:
label: Expected behavior
description: What do you expect to happen?

- type: textarea
id: actual-behavior
attributes:
label: Actual behavior
description: What happens with the steps given above?
label: Expected & Actual behavior
description: What do you expect to happen? and What actually happens with the steps given above?
placeholder: "I expect it to ..., but instead it ..."

- type: textarea
id: screen-media
Expand All @@ -64,6 +59,17 @@ body:
attributes:
label: Logs
description: If your bug includes a crash log, tap on "Share formatted log" at the bottom, click "Copy to clipboard", and paste it here.
placeholder: |
Exception
App language: en
App version: ...
Device: brand MO-DEL
OS Version: Linux brand/model/model:33/build/build:author/key 14 - 33
GMT Time: 2024/../.. ..:..
Crash log:
java.lang.Exception: ...
at ...(...:...)
...
- type: input
id: device-os
Expand Down
8 changes: 4 additions & 4 deletions .github/ISSUE_TEMPLATE/feature_request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,26 +7,26 @@ body:
attributes:
label: "Checklist"
options:
- label: "I made sure that there are *no existing issues* - [open](./issues) or [closed](./issues?q=is%3Aissue+is%3Aclosed)."
- label: "I made sure that there are *no existing issues* - [open](.) or [closed](.?q=is%3Aissue+is%3Aclosed)."
required: true

- type: textarea
id: describe
attributes:
label: "**Is your feature request related to a problem? Please describe.**"
label: "Is your feature request related to a problem? Please describe."
description: A clear and concise description of what the problem is.
placeholder: "eg. I'm always frustrated when ..."

- type: textarea
id: solution
attributes:
label: "**Describe the solution you'd like**"
label: "Describe the solution you'd like"
description: A clear and concise description of what you want to happen.
placeholder: "eg. I want it to ..."

- type: textarea
id: additional_info
attributes:
label: "**Additional context**"
label: "Additional context"
description: Add any other context or screenshots about the feature request here.
placeholder: "eg. I saw App B has ... feature, it has ... and ..., just look at the screenshot that i sent"
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ class ErrorActivity: AppCompatActivity(){
.append("* __Device:__ ${Build.BRAND} ${Build.MODEL}\n")
.append("* __OS Version:__ ${osVersion}\n")
.append("* __GMT Time:__ ${formattedDateTime}\n")
.append("<details><summary><b>Crash log</b></summary><p>\n")
.append("<details><summary><b>Crash log</b></summary><p>\n\n")
.append("```\n${exceptionMessage}\n```\n")
.append("</details><hr>")
.toString()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,9 @@ class SettingsActivity: AppCompatActivity(){
for (key in jsonObject.keys()){
val value = jsonObject.get(key)
when (value){
is String -> prefsEditor?.putString(key, value)
is Int -> prefsEditor?.putInt(key, value)
is Boolean -> prefsEditor?.putBoolean(key, value)
is Int -> prefsEditor?.putInt(key, value)
is String -> prefsEditor?.putString(key, value)
is JSONArray -> {
val stringArray = mutableListOf<String>()
for (i in 0 until value.length()) stringArray.add(value.optString(i))
Expand Down

0 comments on commit 43b121c

Please sign in to comment.