Minor changes

+ From this point on, because AndroidErrorLogger library is fixed and accessible on JitPack.io, this should also fix Android CI builds (and also commiting this will trigger Android CI, so might as well do that too), and no longer need to download whole AEL repo and symlinking and all that just to build app that uses AEL library. + Remove things that accidentally got added (especially the AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA_TODO was so hilarious ::lol::) + [README.md] Fix Android CI badge + [README.md] Change header size a bit + [app/build.gradle.kts] Use "com.github.mdp43140.ael:ael-kt:1.0.1-hf" instead of local project path (see 1st changes) + [app/build.gradle.kts] Little bit of code cleanups
MDP43140 · Dec 13, 2024 · 9531090 · 9531090
1 parent a831696
commit 9531090
Show file tree

Hide file tree

Showing 6 changed files with 16 additions and 40 deletions.
diff --git a/.gitignore b/.gitignore
@@ -40,4 +40,3 @@ hs_err_pid*
 /build/
 .kotlin
 app/src/.disabled
-app/.POC_GetSDCard.java
diff --git a/AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA_TODO.md b/AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA_TODO.md
diff --git a/README.md b/README.md
@@ -1,7 +1,7 @@
 ## LTECleanerFOSS
 A maintained-ish improved fork of @TheRedSpy15's LTE Cleaner
 
-![Android CI](https://github.com/mdp43140/LTECleanerFOSS/workflows/Android%20CI/badge.svg)
+[![Android CI](https://github.com/mdp43140/LTECleanerFOSS/actions/workflows/android.yml/badge.svg?branch=main)](https://github.com/MDP43140/LTECleanerFOSS/actions/workflows/android.yml)
 [![GitHub issues](https://img.shields.io/github/issues/mdp43140/LTECleanerFOSS)](/issues)
 [![License](https://img.shields.io/github/license/mdp43140/LTECleanerFOSS)](/blob/master/LICENSE)
 
@@ -14,14 +14,14 @@ LTE Cleaner only aims to clean your phone by removing safe to delete files, whic
 
 __LTE Cleaner is 100% free, open source, no ads, and deletes everything it claims to.__
 
-## Install
+### Install
 [GitHub release](https://github.com/MDP43140/LTECleanerFOSS/releases)
 [Build it yourself](#compiling-the-app)
 [Original F-Droid (outdated)](https://f-droid.org/packages/theredspy15.ltecleanerfoss)
 [Original source code (outdated)](https://github.com/theredspy15/LTECleanerFOSS)
 [Original GitHub release (outdated)](https://github.com/theredspy15/LTECleanerFOSS)
 
-## Features
+### Features
 - Clipboard clearing
 - Whitelist
 - Daily cleanup
@@ -39,19 +39,19 @@ To do list (not guaranteed because i'm busy irl):
 - Predictive back gestures?
 - Extra optimizations?
 - Code cleanups
-- Compose?
+- Compose? (really low priority, because this will literally take decades to implement, lots of code changes, and importantly will took longer to compile and requires more resource and increases APK size to 50MB!! (see Open Video Editor project, before and after the Compose update))
 - baseline profile (not ready yet...)
 - Clean SD card (has to support minimal Android 10+, hopefully we can use StorageAccessFramework to make this work, but it might be a huge work that can take days, not possible with my spare time)
 - Regex whilelist
 - About screen (designing the UI would be really painful, and using external dependency will also significantly enlarge file size)
 <!-- Scan then clean, instead of doing both at the same time (atleast on some devices that i tested on, it lags when there is so many files)-->
 
-## Screenshots
+### Screenshots
 <img src="Screenshots/ui_main.png" width="200">
 <img src="Screenshots/ui_settings.png" width="200">
 <img src="Screenshots/ui_wl.png" width="200">
 
-## The Team
+### The Team
 <a href="https://github.com/mdp43140/LTECleanerFOSS/graphs/contributors">
 	<img src="https://contrib.rocks/image?repo=mdp43140/LTECleanerFOSS" />
 </a>
@@ -62,7 +62,7 @@ Contribute to this project:
 - Create a [Pull Request](https://opensource.guide/how-to-contribute/#opening-a-pull-request)
 - Translate this app into more languages
 
-## Compiling the app
+### Compiling the app
 First, export some variables (for Linux users. Windows user might want to adjust this a bit):
 ```bash
 export JAVA_HOME="${JAVA_HOME:-/usr/lib/jvm/java-21-openjdk-amd64}"
@@ -74,7 +74,7 @@ Then go to the project root directory, and run this command:
 
 if you're using Windows, change `./gradlew` to `gradlew.bat`
 
-## License
+### License
 [![GNU GPL v3](https://www.gnu.org/graphics/gplv3-127x51.png)](https://www.gnu.org/licenses/gpl-3.0.en.html)
 
 LTE Cleaner is Free Software: You can use, study, share, and improve it at

diff --git a/app/build.gradle.kts b/app/build.gradle.kts
@@ -17,19 +17,9 @@ kotlin {
 android {
 	compileSdk = 35
 	buildToolsVersion = "35.0.0"
-	namespace = "theredspy15.ltecleanerfoss" // eg AndroidManifest.xml had ".App" instead of "namespace.App"
+	namespace = "theredspy15.ltecleanerfoss"
 	defaultConfig {
-		applicationId = "io.mdp43140.ltecleaner" // package name
-		// Actually it can "support" API 21...
-		// if I tried hard enough to make it work,
-		// but it requires more effort, makes maintenance harder,
-		// and cant be installed on Android 14+, as they now require apps
-		// to use minimum SDK of 24.
-		// according to StatCounter & AppBrain,
-		// almost no one uses below 7.0 (24) anyway.
-		// Also, changing SDK can affect things,
-		// not just compatibility (ehm... "Failed to parse APK")
-		// it can also reduce APK size a little bit (based on my tests)
+		applicationId = "io.mdp43140.ltecleaner"
 		minSdk = 24
 		targetSdk = compileSdk
 		versionCode = 64
@@ -55,14 +45,14 @@ android {
 		}
 	}
 	lint {
-		checkReleaseBuilds = false // we did thousands of these on debug builds already...
 		abortOnError = false
+		checkReleaseBuilds = false // we did thousands of these on debug builds already...
 		lintConfig = file("lint.xml")
 	}
 	buildTypes {
 		debug {
-			isDebuggable = true
 			applicationIdSuffix = ".debug"
+			isDebuggable = true
 		}
 		release {
 			isMinifyEnabled = true
@@ -140,8 +130,7 @@ dependencies {
 	// Leak detection
 	debugImplementation("com.squareup.leakcanary:leakcanary-android:2.14")
 	// Error logger
-	implementation(project(":ael_kt"))
-
+	implementation("com.github.mdp43140.ael:ael_kt:1.0.1-hf")
 	// Tests (AndroidJUnitRunner & JUnit Rules, Assertions)
 	androidTestImplementation("androidx.test:runner:1.6.2")
 	androidTestImplementation("androidx.test.ext:junit:1.2.1")

diff --git a/app/src/main/res/values/styles.xml b/app/src/main/res/values/styles.xml
@@ -26,5 +26,5 @@
 		<item name="widgetLayout">@layout/preference_material_switch</item>
 	</style>
 	<!-- Custom error logger theme -->
-	<style name="ErrLoggerTheme" parent="AppTheme"/>
+	<style name="AEL_Theme" parent="AppTheme"/>
 </resources>
diff --git a/settings.gradle.kts b/settings.gradle.kts
@@ -1,8 +1,3 @@
-/*
- * SPDX-FileCopyrightText: 2020-2023 Hunter J Drum
- * SPDX-FileCopyrightText: 2024 MDP43140
- * SPDX-License-Identifier: GPL-3.0-or-later
- */
 pluginManagement {
 	repositories {
 		google()
@@ -18,12 +13,11 @@ dependencyResolutionManagement {
 		maven("https://jitpack.io")
 	}
 }
-// TODO: replacing project with dep substitution throws "unresolved reference ErrorLogger" error
 //includeBuild("../ael"){
 //	dependencySubstitution {
-//		substitute(module("io.mdp43140:ael-kt")).using(project(":ael_kt"))
+//		substitute(module("com.github.mdp43140.ael:ael-kt")).using(project(":ael_kt"))
 //	}
 //}
 
 rootProject.name = "LTE Cleaner"
-include(":app",":ael_kt")
+include(":app")
-Original file line number
+Diff line change
@@ Expand Up / @@ -40,4 +40,3 @@ hs_err_pid* @@
     /build/
     .kotlin
     app/src/.disabled
-    app/.POC_GetSDCard.java