Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Mac OS Tests #362

Merged
merged 13 commits into from
Dec 4, 2024
Merged

Fix Mac OS Tests #362

merged 13 commits into from
Dec 4, 2024

Conversation

ssolson
Copy link
Contributor

@ssolson ssolson commented Dec 2, 2024

DOLfYN tests are failing on macos. THis PR will fix this issue.

This first attempt normalizes the data to see if that reduces the noise in the comparison.

ssolson added 11 commits August 9, 2024 09:03
@ssolson
matplotlib >=3.8
3b5578b
@ssolson
Merge branch 'develop' of https://github.com/MHKiT-Software/MHKiT-Python
6c62bfd 
 into develop
@ssolson
Merge branch 'develop' of https://github.com/MHKiT-Software/MHKiT-Python
738e3d0 
 into develop
@ssolson
Merge branch 'develop' of https://github.com/MHKiT-Software/MHKiT-Python
f91ef77 
 into develop
@ssolson
Merge branch 'develop' of https://github.com/MHKiT-Software/MHKiT-Python
20487d5 
 into develop
@ssolson
Merge branch 'develop' of https://github.com/MHKiT-Software/MHKiT-Python
0f420fc 
 into develop
@ssolson
Merge branch 'develop' of https://github.com/MHKiT-Software/MHKiT-Python
a20759d 
 into develop
@ssolson
Merge branch 'develop' of https://github.com/MHKiT-Software/MHKiT-Python
87e4464 
 into develop
@ssolson
Merge branch 'develop' of https://github.com/MHKiT-Software/MHKiT-Python
47135ae 
 into develop
@ssolson
normalize data to pass on macos
77bff41
@ssolson
temp run pulls against develop on macos
a588b1c
@ssolson ssolson added the Clean Up Improve code consistency and readability label Dec 2, 2024
@ssolson ssolson self-assigned this Dec 2, 2024
@ssolson
Copy link
Contributor Author

ssolson commented Dec 2, 2024

@jmcvey3 Mac OS fails on the DOLfYN test_motion:test_motion_adv test. (ubuntu and Windows both pass). See #361.

image

I tried normalizing the data but that did not work so I reduced the absolute tolerance from 1e-7 to 1e-6 and it passes.

Are you okay with this modification? Would you approach it differently?

@ssolson ssolson marked this pull request as ready for review December 3, 2024 17:04
@ssolson ssolson merged commit eb360a0 into MHKiT-Software:develop Dec 4, 2024
43 checks passed
@ssolson ssolson mentioned this pull request Dec 4, 2024
Merged
@ssolson ssolson deleted the mac_tests branch December 5, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ssolson ssolson

Labels
Clean Up Improve code consistency and readability
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ssolson