Switch to writing thumbnails as jpgs #1055
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will hopefully reduce load time and server load.
This merge also changes the threshold on the aspect ratio of images at which images are considered "vertical" (and therefore given substantially taller thumbnails). Before, the threshold was 1, meaning nearly square figures could end up with substantially larger or smaller size depending on tiny variations in width, which made galleries of squarish figures quite inconsistent. The threshold is now set to 0.75 (i.e. 3:4). Weird behavior could still be seen with figures near this aspect ratio but we don't currently have figures like that in our galleries. (There are technical and aesthetic reasons that it is necessary to specify a fixed height for horizontal and vertical figures, rather than, for example, constraining either the height or the width.)
Checklist
Testing
comment in the PR documents testing used to verify the changes