Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flip to Shhh] Support bringup #26

Open
imachabeich opened this issue Dec 30, 2018 · 11 comments
Open

[Flip to Shhh] Support bringup #26

imachabeich opened this issue Dec 30, 2018 · 11 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@imachabeich
Copy link

Describe the bug
After installing the module, there is no option to enable this feature.

Expected behavior
There should be an option to enable 'Flip to Shhh'.

Smartphone (please complete the following information):

  • Device: [Samsung Galaxy S4 and Samsung galaxy S6]
  • OS: [e.g. Android 9.0]
  • Version [2.1.2]
@imachabeich imachabeich added the bug Something isn't working label Dec 30, 2018
@TheGabrielHoward
Copy link

It appears for me, but the function isn't enabled

@ThatNerdyPikachu
Copy link
Collaborator

Yeah, we still need to enable something, as seen here.

@thehappydinoa
Copy link
Collaborator

I believe the issue lies within the mo1654d function

this.f9702f.getPackageManager().getPackageInfo(this.f9715s.mo740a(), 0).getLongVersionCode() < this.f9714r

evaluates to True and throws

f9697a.mo1036a(Level.WARNING)).mo1048a("com/google/android/apps/wellbeing/autodnd/impl/AutoDndManagerImpl", "setAutoDndEnabled", 294, "AutoDndManagerImpl.java")).mo1050a("Auto DND is not supported and should not be set as enabled.")

@ThatNerdyPikachu
Copy link
Collaborator

@imachabeich Btw, where are you checking? (You should be checking in System > Gestures)

@Magisk-Modules-Repo Magisk-Modules-Repo deleted a comment Dec 30, 2018
@ThatNerdyPikachu ThatNerdyPikachu changed the title [Bug] Flip top Shhh ist not enabled [Bug] Flip to Shhh is not enabled Dec 30, 2018
@thehappydinoa thehappydinoa changed the title [Bug] Flip to Shhh is not enabled Flip to Shhh is not enabled Dec 30, 2018
@imachabeich
Copy link
Author

Yeah, I checked in System > Gestures and System > Digital Wellbeing.

@lzlrd
Copy link
Collaborator

lzlrd commented Dec 31, 2018

I have a similar issue too, we're working on it @imachabeich.

@thehappydinoa thehappydinoa added the help wanted Extra attention is needed label Jan 26, 2019
@AuroraWright
Copy link

@thehappydinoa
Copy link
Collaborator

@AuroraWright I will check out adding this now.

@lzlrd
Copy link
Collaborator

lzlrd commented Mar 15, 2019

@AuroraWright it's added in here eb1d063.

EDIT: After some testing by @Stallix your port still doesn't work. There may be a kernel side/userspace change necessary for Flipp to Shh to function.

@lzlrd lzlrd mentioned this issue Mar 15, 2019
@AuroraWright
Copy link

AuroraWright commented Mar 15, 2019

Interesting, the apk does enable the feature on my Pixel 2 but I suppose all Pixels might be predisposed for the feature to be unlocked in the future. The only "unique" thing that Flip to Shhh has (that I can tell) is that it uses the proximity sensor.

@lzlrd
Copy link
Collaborator

lzlrd commented Mar 16, 2019

@AuroraWright Flip to Shh relies on gyro too IIRC, but also it's possible that it checks for a sysnode of the Pixel's proximity sensors/gyro which are different on other devices.

@lzlrd lzlrd added enhancement New feature or request and removed bug Something isn't working labels Mar 21, 2019
@lzlrd lzlrd changed the title Flip to Shhh is not enabled Flip to Shhh support Mar 21, 2019
@lzlrd lzlrd changed the title Flip to Shhh support Flip to Shhh: Add Support Jun 1, 2019
@lzlrd lzlrd changed the title Flip to Shhh: Add Support Flip to Shhh: Support expected Jun 1, 2019
@lzlrd lzlrd changed the title Flip to Shhh: Support expected [Flip to Shhh] Support bringup Jun 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Development

No branches or pull requests

6 participants