Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.9.2 #76

Merged
merged 16 commits into from
Mar 21, 2019
Merged

v2.9.2 #76

merged 16 commits into from
Mar 21, 2019

Conversation

JohnFawkes
Copy link
Collaborator

Signed-off-by: JohnFawkes [email protected]

Signed-off-by: JohnFawkes <[email protected]>
Signed-off-by: JohnFawkes <[email protected]>
Copy link
Collaborator

@thehappydinoa thehappydinoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall pretty solid, just some traces of AutoDND

README.md Outdated Show resolved Hide resolved
pix3lify.sh Outdated Show resolved Hide resolved
common/service.sh Outdated Show resolved Hide resolved
common/uninstall.sh Show resolved Hide resolved
Signed-off-by: JohnFawkes <[email protected]>
README.md Outdated
@@ -56,10 +56,18 @@ As a Mi A1 user, I was stuck with Stock Oreo 8.0.0 without Oreo custom ROMs when

## ⭐ Features Under Development
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove this header?

Signed-off-by: JohnFawkes <[email protected]>
Signed-off-by: JohnFawkes <[email protected]>
By using @AuroraWright 's port for Flip to Shh and @skittles9823 's
dynamic fonts.xml modification we set Product Sans as a default.
@lzlrd
Copy link
Collaborator

lzlrd commented Mar 15, 2019

Forgot to add I fixed the Markup issue for lower than Pie devices.

@lzlrd
Copy link
Collaborator

lzlrd commented Mar 15, 2019

#78 solved
#80 nearly there
#26 rip
#61 cannot be done universally

@lzlrd
Copy link
Collaborator

lzlrd commented Mar 16, 2019

@Stallix fixed up what you asked in TG. @JohnFawkes is there anything left or shall we push to master?

@lzlrd lzlrd dismissed thehappydinoa’s stale review March 16, 2019 11:27

T'was removed with a later commit.

@lzlrd lzlrd requested a review from thehappydinoa March 16, 2019 11:27
@lzlrd lzlrd changed the title v2.9.1 v2.9.2 Mar 16, 2019
Copy link
Collaborator

@thehappydinoa thehappydinoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check file permissions of system/app/MarkupGoogle/MarkupGoogle1.apk


- Flip to Shhh (mileage may vary)
### v2.9.1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bump

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version change, right?

@@ -2,7 +2,6 @@
# More info in the main Magisk thread

if [ $API -ge 28 ] && [ $FULL ]; then
pm enable "com.google.android.apps.wellbeing/com.google.android.apps.wellbeing.autodnd.ui.AutoDndGesturesSettingsActivity"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Figure out how to remove updates before installing WellBeing

Copy link
Collaborator

@lzlrd lzlrd Mar 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you referring to Aurora's method? Pretty sure @Stallix tested and it doesn't work.

I guess this line is unnecessary code then too.

If we did want to remove updates it would be a part of the pm --uninstall command or wiping /data/data/x and /data/app/x.

@thehappydinoa thehappydinoa self-requested a review March 17, 2019 02:42
@lzlrd
Copy link
Collaborator

lzlrd commented Mar 17, 2019

Check file permissions of system/app/MarkupGoogle/MarkupGoogle1.apk

I'm not actually sure how to change that on Windows, would you be able to push a fix?

EDIT: Sorted

@lzlrd
Copy link
Collaborator

lzlrd commented Mar 17, 2019

@thehappydinoa I think I sorted out all the issues there.

This will enforce all app folders and *.apks have correct perms.
@lzlrd
Copy link
Collaborator

lzlrd commented Mar 17, 2019

@JohnFawkes can u checkout the last commit I did there? Seems it can be improved.

@lzlrd
Copy link
Collaborator

lzlrd commented Mar 21, 2019

Yay time

@lzlrd lzlrd merged commit a888d23 into Magisk-Modules-Repo:master Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants