Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] 소원 생성 시 슬랙 연동 #158

Merged
merged 4 commits into from
Dec 20, 2023
Merged

Conversation

wlwpfh
Copy link
Collaborator

@wlwpfh wlwpfh commented Dec 19, 2023

✨ 관련 이슈

closed #157

✨ 변경 사항 및 이유

  • 소원 생성 시에도 슬랙에 알림이 가도록 설정하였습니다.
  • 회원가입과 다른 채널을 이용합니다.
  • 하드코딩 값들을 따로 모았습니다.

✨ PR Point

  • application-dev.ymlapplication-test.yml 값을 업데이트했습니다.

@wlwpfh wlwpfh requested a review from yujindonut December 19, 2023 13:52
@wlwpfh wlwpfh self-assigned this Dec 19, 2023
@wlwpfh wlwpfh merged commit c18ad49 into develop Dec 20, 2023
1 check passed
Copy link
Member

@yujindonut yujindonut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

졍언니 넘 최고입니다 .. 응용까지 ..
넘 고생하셨습니다 ..

textField.put("type", "section");
textField.set("text", createTextFieldNode("새로운 소원이 생성되었어요!"));
textField.put(TYPE, SECTION);
textField.set(TEXT, createTextFieldNode(SlackSuccessMessage.SUCCESS_CREATE_WISH.getMessage()));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코드가 훨씬 깔끔해졌네요 ,,,, 정말 짱입니다 !!

@@ -0,0 +1,12 @@
package com.sopterm.makeawish.common.message.slack;

public class SlackField {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

진짜 넘넘 깔꼼해요~!~!

@wlwpfh wlwpfh deleted the jiyoung_#157-slack-alarm branch February 6, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ADD] 슬랙 소원 생성 시 알림 설정
2 participants