MDEV-35905: Revert CONC-710 induced mysqlbinlog FIXME #3782
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mariadb-corporation/mariadb-connector-c@1a2ed3f
and
mariadb-corporation/mariadb-connector-c@78e56a7
of CONC-710 mistakenly moved Item_result from mariadb_com.h to
mariadb_rpl.h thinking it was only used by Connector/C's binlog API;
however it is also used by mysqlbinlog in the server. This broke
server compilation.
e41145f
provided a temporary fix to re-define Item_result in mysqlbinlog.cc
to get the build working
mariadb-corporation/mariadb-connector-c@75d381f
reverted the change from CONC-710 in libmariadb to move Item_result
back to mariadb_com.h
This patch updates the server libmariadb version to include the
latest connector-c fix, and reverts the old temporary fix, so
mysqlbinlog uses Item_result from mariadb_com.h again.
It was initially tested locally by compiling and running MTR with an
updated
libmariadb
submodule, and then verified via CI runs,e.g. this build