style: fix prefer-const linter rule violations

Marus · Jan 17, 2025 · d855332 · d855332
1 parent 0c97ebe
commit d855332
Show file tree

Hide file tree

Showing 7 changed files with 17 additions and 30 deletions.
diff --git a/eslint.config.mjs b/eslint.config.mjs
@@ -80,7 +80,6 @@ export default tseslint.config(
             'no-cond-assign': 'off',                                    // 21 instances
             'no-empty': 'off',                                          // 19 instances
             '@typescript-eslint/restrict-template-expressions': 'off',  // 17 instances
-            'prefer-const': 'off',                                      // 13 instances
             '@typescript-eslint/require-await': 'off',                  // 11 instances
         }
     },

diff --git a/src/backend/disasm.ts b/src/backend/disasm.ts
@@ -519,8 +519,7 @@ export class GdbDisassembler {
                 const entireRangeGood = range.isKnownStart || this.isRangeInValidMem(startAddress, endAddress);
                 const end = endAddress;
                 // const end = range.isData ? endAddress : this.clipHigh(endAddress, endAddress + this.maxInstrSize); // Get a bit more for functions
-                let cmd: string;
-                cmd = `data-disassemble -s ${hexFormat(startAddress)} -e ${hexFormat(end)} -- 5`;
+                const cmd = `data-disassemble -s ${hexFormat(startAddress)} -e ${hexFormat(end)} -- 5`;
                 if (this.doTiming) {
                     const symName = range.symNode ? ` (${range.symNode.symbol.name})` : '';
                     const count = `${end - startAddress} bytes`.padStart(15);

diff --git a/src/backend/gdb_expansion.ts b/src/backend/gdb_expansion.ts
@@ -58,14 +58,9 @@ export function expandValue(variableCreate: (value: string | object, opts?: { ar
     };
 
     const stack = [root];
-    let parseValue;
-    let parseCommaResult;
-    let parseCommaValue;
-    let parseResult;
-    let createValue;
     let variable = '';
 
-    const getNamespace = (variable): string => {
+    function getNamespace(variable): string {
         let namespace = '';
         let prefix = '';
         stack.push(variable);
@@ -91,7 +86,7 @@ export function expandValue(variableCreate: (value: string | object, opts?: { ar
         return prefix + namespace;
     };
 
-    const parseTupleOrList = () => {
+    function parseTupleOrList() {
         value = value.trim();
         if (value[0] !== '{') {
             return undefined;
@@ -151,7 +146,7 @@ export function expandValue(variableCreate: (value: string | object, opts?: { ar
         return undefined;
     };
 
-    const parsePrimitive = () => {
+    function parsePrimitive() {
         let primitive: any;
         let match;
         value = value.trim();
@@ -191,7 +186,7 @@ export function expandValue(variableCreate: (value: string | object, opts?: { ar
         return primitive;
     };
 
-    parseValue = () => {
+    function parseValue() {
         value = value.trim();
         if (value[0] === '"') {
             return parseCString();
@@ -202,7 +197,7 @@ export function expandValue(variableCreate: (value: string | object, opts?: { ar
         }
     };
 
-    parseResult = (pushToStack: boolean = false) => {
+    function parseResult(pushToStack: boolean = false) {
         value = value.trim();
         const variableMatch = resultRegex.exec(value);
         if (!variableMatch) {
@@ -220,7 +215,7 @@ export function expandValue(variableCreate: (value: string | object, opts?: { ar
         return createValue(name, val);
     };
 
-    createValue = (name, val) => {
+    function createValue(name, val) {
         let ref = 0;
         if (typeof val === 'object') {
             ref = variableCreate(val);
@@ -246,7 +241,7 @@ export function expandValue(variableCreate: (value: string | object, opts?: { ar
         };
     };
 
-    parseCommaValue = () => {
+    function parseCommaValue() {
         value = value.trim();
         if (value[0] !== ',') {
             return undefined;
@@ -255,7 +250,7 @@ export function expandValue(variableCreate: (value: string | object, opts?: { ar
         return parseValue();
     };
 
-    parseCommaResult = (pushToStack: boolean = false) => {
+    function parseCommaResult(pushToStack: boolean = false) {
         value = value.trim();
         if (value[0] !== ',') {
             return undefined;

diff --git a/src/backend/mi_parse.ts b/src/backend/mi_parse.ts
@@ -206,12 +206,7 @@ export function parseMI(output: string): MINode {
         return str;
     };
 
-    let parseValue;
-    let parseCommaResult;
-    let parseCommaValue;
-    let parseResult;
-
-    const parseTupleOrList = () => {
+    function parseTupleOrList() {
         if (output[0] !== '{' && output[0] !== '[') {
             return undefined;
         }
@@ -249,7 +244,7 @@ export function parseMI(output: string): MINode {
         return undefined;
     };
 
-    parseValue = () => {
+    function parseValue() {
         if (output[0] === '"') {
             return parseCString();
         } else if (output[0] === '{' || output[0] === '[') {
@@ -259,7 +254,7 @@ export function parseMI(output: string): MINode {
         }
     };
 
-    parseResult = () => {
+    function parseResult() {
         const variableMatch = variableRegex.exec(output);
         if (!variableMatch) {
             return undefined;
@@ -269,15 +264,15 @@ export function parseMI(output: string): MINode {
         return [variable, parseValue()];
     };
 
-    parseCommaValue = () => {
+    function parseCommaValue() {
         if (output[0] !== ',') {
             return undefined;
         }
         output = output.substr(1);
         return parseValue();
     };
 
-    parseCommaResult = () => {
+    function parseCommaResult() {
         if (output[0] !== ',') {
             return undefined;
         }

diff --git a/src/live-watch-monitor.ts b/src/live-watch-monitor.ts
@@ -252,8 +252,7 @@ export class VariablesHandler {
             session.sendResponse(response);
             return;
         }
-        let id: number | string | VariableObject | ExtendedVariable;
-        id = this.variableHandles.get(args.variablesReference);
+        const id = this.variableHandles.get(args.variablesReference);
         if (typeof id === 'object') {
             if (id instanceof VariableObject) {
                 const pVar = id;

diff --git a/src/remote/src/extension.ts b/src/remote/src/extension.ts
@@ -13,7 +13,7 @@ export class CortexDebugRemote {
     constructor(public context: vscode.ExtensionContext) {
         console.log('in CortexDebugRemote::constructor');
         vscode.window.showInformationMessage('cortex-debug-remote activated!');
-        let disposable = vscode.commands.registerCommand('cortex-debug-remote.helloWorld', this.hello.bind(this));
+        const disposable = vscode.commands.registerCommand('cortex-debug-remote.helloWorld', this.hello.bind(this));
 
         context.subscriptions.push(disposable);
         this.server = new Server(context);

diff --git a/src/remote/src/server.ts b/src/remote/src/server.ts
@@ -82,7 +82,7 @@ class Client {
             new rpc.StreamMessageWriter(this.socket, 'utf-8')
         );
 
-        let notification = new rpc.NotificationType<Interfaces.eventArgs>('event');
+        const notification = new rpc.NotificationType<Interfaces.eventArgs>('event');
         this.connection.onNotification(notification, (param: Interfaces.eventArgs) => {
             console.log(param);
         });