Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/647-attestation-trust-anchor-handling #650

Merged
merged 8 commits into from
Dec 6, 2024

Conversation

MasterKale
Copy link
Owner

@MasterKale MasterKale commented Dec 5, 2024

This PR refines attestation statement certificate chain verification to understand that trust anchors may not always be root certificates. Additionally, all certificates in the chain are checked for revocation and whether they are in their valid time window.

Fixes #647.

@MasterKale MasterKale force-pushed the fix/647-attestation-trust-anchor-handling branch from 710745d to e0a9113 Compare December 5, 2024 08:29
@MasterKale MasterKale added this to the v12.1.0 milestone Dec 6, 2024
@MasterKale MasterKale merged commit 4463107 into master Dec 6, 2024
2 checks passed
@MasterKale MasterKale deleted the fix/647-attestation-trust-anchor-handling branch December 6, 2024 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:server @simplewebauthn/server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FIDO2 - attestationRootCertificates does not represent a certificate chain
1 participant