changed node.toml.erb and deployment.yaml.erb. #13
Conversation
Signed-off-by: Maximilian Meister <[email protected]>
there were some changes that rendered the config format invalid Signed-off-by: Maximilian Meister <[email protected]>
since k8s 1.9.4 configmap mounts are read only so just copy the original configmap to another place and edit and use it from there do all that in the container without an init container to avoid remounting the new config file location fixes MaximilianMeister#7 Signed-off-by: Maximilian Meister <[email protected]>
ethereum/go-ethereum#15557 has been merged Signed-off-by: Maximilian Meister <[email protected]>
if it's public, no bootnode and no genesis block will be created nodes should then (in theory) connect to the hardcoded bootnodes from geth if that doesnt happen we need to set them explicitly in the config fixes MaximilianMeister#6 Signed-off-by: Maximilian Meister <[email protected]>
There was a problem hiding this comment.
hey @redtree0 thanks for the pull request, i left you a couple of comments to address
| @@ -30,7 +30,7 @@ | |||
| // load web3.js | |||
| var Web3 = require('web3'); | |||
| var web3 = new Web3(); | |||
| web3.setProvider(new web3.providers.HttpProvider('http://localhost:8545')); | |||
| web3.setProvider(new web3.providers.HttpProvider('http://192.168.99.20:8545')); | |||
There was a problem hiding this comment.
i'd leave the more generic localhost here
| @@ -3,7 +3,6 @@ | |||
| <% | |||
| def set_node_template_vars(values) | |||
| @Eth_Etherbase = values["geth"]["Eth_Etherbase"] | |||
| @Eth_MinerThreads = values["geth"]["Eth_MinerThreads"] | |||
There was a problem hiding this comment.
I agree this can be dropped, as it seems to have no effect on the config file. however when we drop it could you also drop it from the other places? README.md, kuberneteth, kuberneteth.yaml, scripts/generate_nodes.sh come to my mind
| @@ -5,9 +5,8 @@ LightPeers = 20 | |||
| DatabaseCache = 128 | |||
| <%- if @Eth_Etherbase && @Eth_MinerThreads -%> | |||
There was a problem hiding this comment.
here you would need to drop the miner threads too
| @@ -47,7 +46,7 @@ HTTPHost = "0.0.0.0" | |||
| HTTPPort = <%= @Node_HTTPPort %> | |||
| HTTPCors = ["*"] | |||
| HTTPVirtualHosts = ["*"] | |||
| HTTPModules = ["db", "eth", "net", "web3", "personal", "web3"] | |||
| HTTPModules = ["db", "eth", "net", "web3", "personal", "miner"] | |||
There was a problem hiding this comment.
is 'miner' really a module? i can see web3 is redundant, so maybe we just drop it from the list?
| <% end -%> | ||
| GasPrice = 18000000000 | ||
| MinerGasPrice = 18000000000 |
the docs might be outdated, the safest bet to get to the newest config file would be: you can pass additional flags (e.g. |
|
Can I help with this so we can make this repo working again? @MaximilianMeister |
@edisinovcic hi thanks for the offer, tbh i havent tried it for a long time, especially with newer k8s releases. you can definitely submit fixes if you already have sth in mind. but there's also the ethereum helmchart which offers even more configurability than this repo. with the extra cost of installing helm... |
|
Yeah, I've managed to fix it. Will submit later. Tnx for the link. |
|
Before I submit a pull request I would like to add a bootnode registry (like there is in chart) but am not able to migrate it to Clique, do you have some repo for that? Tnx in advance! |
MaximilianMeister
force-pushed
the
master
branch
from
b15f60a to
3aa76bb
Compare
@MaximilianMeister
I solved this problem. I found a same log in miner-pod .
I look https://godoc.org/github.com/ethereum/go-ethereum/eth#Config
GasPrice -> MinerGasPrice, MinerThreads -> not found
I changed node.toml.erb and deployment.yaml.erb.
Pull request