Enable collect_test_cases.py to work for TF-PSA-Crypto #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Harry-Ramsey
force-pushed
the
independent-collect-test-cases
branch
from
63203e3 to
a958e4d
Compare
ronald-cron-arm
requested changes
Jan 17, 2025
Harry-Ramsey
force-pushed
the
independent-collect-test-cases
branch
from
a958e4d to
cb943bc
Compare
|
@Harry-Ramsey I think you need to base it on the head of mbedtls-framework. The CI has started to complain. |
valeriosetti
requested changes
Jan 17, 2025
| @@ -142,3 +142,16 @@ def is_mbedtls_3_6() -> bool: | |||
| return False | |||
| with open(os.path.join(root, 'include', 'mbedtls', 'build_info.h'), 'r') as f: | |||
| return re.search(r"#define MBEDTLS_VERSION_NUMBER.*0x0306", f.read()) is not None | |||
|
|
|||
| def is_mbedtls_4_x() -> bool: | |||
There was a problem hiding this comment.
Isn't this check not really future proof? I mean, I know that 4.x is the near future and we're going to deal with it for a while, but this check is going to fail in >= 5.x. At the same time we don't know yet if tests based on this check will change by that time...
Can't we instead live with only is_mbedtls_3.6 and use not is_mbedtls_3.6 in collect_test_cases.py in place of this new function?
There was a problem hiding this comment.
That's a good point. Thus let's stick to:
if build_tree.looks_like_mbedtls_root(project_root) and \
not build_tree.is_mbedtls_3_6():
and no need to add is_mbedtls_4_x.
There was a problem hiding this comment.
Fixed and rebased, thanks.
Harry-Ramsey
force-pushed
the
independent-collect-test-cases
branch
2 times, most recently
from
20d63ce to
246dfa2
Compare
valeriosetti
previously approved these changes
Jan 17, 2025
ronald-cron-arm
previously approved these changes
Jan 17, 2025
This commit adapts collect_test_cases.py to work for Mbed TLS and TF-PSA-Crypto. Signed-off-by: Harry Ramsey <[email protected]>
Harry-Ramsey
dismissed stale reviews from ronald-cron-arm and valeriosetti
via
049270e
Harry-Ramsey
force-pushed
the
independent-collect-test-cases
branch
from
246dfa2 to
049270e
Compare
valeriosetti
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adapts collect_test_cases.py to work for Mbed TLS and TF-PSA-Crypto.
PR checklist
Please add the numbers (or links) of the associated pull requests for consuming branches. You can omit branches where this pull request is not needed.
Notes for the submitter
Please refer to the contributing guidelines, especially the
checklist for PR contributors.
Help make review efficient: