fix customer cron with empty address (#122)

Memurame · Jun 21, 2024 · 0d1b82e · 0d1b82e
1 parent 9cbcbf0
commit 0d1b82e
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/app/Controllers/CronController.php b/app/Controllers/CronController.php
@@ -523,8 +523,10 @@ public function abacusSync(){
             }
 
             $customer->syncWithAbacus();
-
-            model('CustomerModel')->save($customer);
+            if($customer->hasChanged()){
+                model('CustomerModel')->save($customer);
+            }
+
         }
     }
 }
diff --git a/app/Controllers/CustomersController.php b/app/Controllers/CustomersController.php
@@ -30,8 +30,8 @@ public function addAbacus($addressnumber){
             return redirect()->route("customer.index")->with("msg_error", "Kein Abacus Eintrag zu dieser Nummer gefunden. Erstellen eines Kunden kann nicht ausgeführt werden.");
         }
 
-        $customer = $customerModel->where('addressnumber', $address->abacus)->first();
-        if($customer){
+        $checkCustomer = $customerModel->where('addressnumber', $address->abacus)->first();
+        if($checkCustomer){
             return redirect()->route("customer.index")->with("msg_error", "Es existiert bereits ein Kunde mit dieser Adressnumer.");
         }
 

diff --git a/app/Entities/Customer.php b/app/Entities/Customer.php
@@ -95,6 +95,8 @@ public function syncwithAbacus($addressnumber = null){
         $address = model('AbaAddressModel')
                 ->where('abacus', $this->addressnumber)
                 ->first();
+        if(!$address) return;
+
 
         $name = $address->lastname;
         if($address->firstname) $name .= ' ' . $address->firstname;