debug language server startup #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
friedbrice
commented
Feb 1, 2024
friedbrice
commented
Feb 1, 2024
Comment on lines
-65
to
-67
| finally { | ||
| if (t) args.close(t) | ||
| } |
There was a problem hiding this comment.
so it turns out i was closing the server just as soon as i was opening it, i think. actually, i'm not sure what the problem was.
friedbrice
commented
Feb 1, 2024
| @@ -12,6 +12,21 @@ export function makeClient(config: LanguageConfig): vscode.Disposable { | |||
| const { languageId, serverCommand } = config | |||
| if (!languageId || !serverCommand) return vscode.Disposable.from() | |||
|
|
|||
| const serverExecutable = { | |||
There was a problem hiding this comment.
The LSP client library will manage the child process for you if you just give it a process spec.
This is how the official Haskell extension launches HLS.
josephsumabat
approved these changes
Feb 1, 2024
|
A PR to release these changes has been created, bumping the version from 2.0.2 to 2.0.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes the language server startup logic.