-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Unflatten selectors and convert to TypeScript #29014
Draft
MajorLift
wants to merge
13
commits into
jongsun/perf/redux/241204-unflatten-metamask-slice
Choose a base branch
from
jongsun/perf/redux/241206-convert-selectors-to-typescript
base: jongsun/perf/redux/241204-unflatten-metamask-slice
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
refactor: Unflatten selectors and convert to TypeScript #29014
MajorLift
wants to merge
13
commits into
jongsun/perf/redux/241204-unflatten-metamask-slice
from
jongsun/perf/redux/241206-convert-selectors-to-typescript
+6,484
−5,354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
MajorLift
added
team-tiger
Tiger team (for tech debt reduction + performance improvements)
and removed
team-wallet-framework
labels
Dec 9, 2024
MajorLift
force-pushed
the
jongsun/perf/redux/241206-convert-selectors-to-typescript
branch
from
December 9, 2024 15:43
d47b4eb
to
143f1a2
Compare
MajorLift
force-pushed
the
jongsun/perf/redux/241204-unflatten-metamask-slice
branch
from
December 9, 2024 15:46
ba499fd
to
7ad7c9a
Compare
MajorLift
changed the title
perf: Unflatten
perf: Unflatten Dec 9, 2024
metamask
slice selectors and convert to TypeScriptmetamask
slice selectors and convert to TypeScript (3/5)
MajorLift
force-pushed
the
jongsun/perf/redux/241204-unflatten-metamask-slice
branch
from
December 9, 2024 18:55
7ad7c9a
to
e17a049
Compare
MajorLift
force-pushed
the
jongsun/perf/redux/241206-convert-selectors-to-typescript
branch
4 times, most recently
from
December 10, 2024 12:10
3880292
to
66188c8
Compare
MajorLift
changed the title
perf: Unflatten
perf: Unflatten selectors and convert to TypeScript (3/5)
Dec 10, 2024
metamask
slice selectors and convert to TypeScript (3/5)
MajorLift
changed the title
perf: Unflatten selectors and convert to TypeScript (3/5)
perf: Convert all selectors to TypeScript and unflatten references to Dec 10, 2024
metamask
slice (3/5)
MajorLift
force-pushed
the
jongsun/perf/redux/241204-unflatten-metamask-slice
branch
from
December 10, 2024 14:37
e17a049
to
168e2b7
Compare
MajorLift
force-pushed
the
jongsun/perf/redux/241206-convert-selectors-to-typescript
branch
from
December 10, 2024 14:41
66188c8
to
dd75333
Compare
MajorLift
force-pushed
the
jongsun/perf/redux/241204-unflatten-metamask-slice
branch
2 times, most recently
from
December 10, 2024 15:15
0971827
to
c557fee
Compare
MajorLift
force-pushed
the
jongsun/perf/redux/241206-convert-selectors-to-typescript
branch
2 times, most recently
from
December 10, 2024 15:35
f4ebdb6
to
63d8618
Compare
MajorLift
force-pushed
the
jongsun/perf/redux/241204-unflatten-metamask-slice
branch
from
December 10, 2024 15:35
c557fee
to
8384a85
Compare
MajorLift
force-pushed
the
jongsun/perf/redux/241206-convert-selectors-to-typescript
branch
from
December 10, 2024 16:35
4419d3e
to
f8ca26b
Compare
MajorLift
force-pushed
the
jongsun/perf/redux/241204-unflatten-metamask-slice
branch
from
December 10, 2024 18:01
8384a85
to
44dde0e
Compare
MajorLift
force-pushed
the
jongsun/perf/redux/241206-convert-selectors-to-typescript
branch
from
December 10, 2024 18:01
f8ca26b
to
ebdd010
Compare
MajorLift
force-pushed
the
jongsun/perf/redux/241204-unflatten-metamask-slice
branch
from
December 10, 2024 18:15
44dde0e
to
cf9e3ae
Compare
MajorLift
force-pushed
the
jongsun/perf/redux/241206-convert-selectors-to-typescript
branch
4 times, most recently
from
December 10, 2024 20:16
14b4b24
to
062dcc8
Compare
MajorLift
force-pushed
the
jongsun/perf/redux/241204-unflatten-metamask-slice
branch
from
December 11, 2024 09:35
cf9e3ae
to
f854428
Compare
MajorLift
force-pushed
the
jongsun/perf/redux/241206-convert-selectors-to-typescript
branch
from
January 6, 2025 12:51
d062d2c
to
f629232
Compare
MajorLift
force-pushed
the
jongsun/perf/redux/241204-unflatten-metamask-slice
branch
from
January 6, 2025 16:18
62d01dd
to
b1ce481
Compare
MajorLift
force-pushed
the
jongsun/perf/redux/241206-convert-selectors-to-typescript
branch
2 times, most recently
from
January 6, 2025 18:13
00b71d0
to
8f18a7a
Compare
MajorLift
force-pushed
the
jongsun/perf/redux/241204-unflatten-metamask-slice
branch
2 times, most recently
from
January 6, 2025 19:39
1add77c
to
c47ed91
Compare
MajorLift
force-pushed
the
jongsun/perf/redux/241206-convert-selectors-to-typescript
branch
from
January 6, 2025 20:05
13db6b8
to
689dc40
Compare
MajorLift
added
DO-NOT-MERGE
Pull requests that should not be merged
team-extension-platform
labels
Jan 6, 2025
MajorLift
force-pushed
the
jongsun/perf/redux/241206-convert-selectors-to-typescript
branch
from
January 7, 2025 12:14
3d79a33
to
89263ea
Compare
MajorLift
force-pushed
the
jongsun/perf/redux/241206-convert-selectors-to-typescript
branch
from
January 7, 2025 17:39
d656eaa
to
7cab4c4
Compare
MajorLift
force-pushed
the
jongsun/perf/redux/241206-convert-selectors-to-typescript
branch
from
January 7, 2025 17:45
7cab4c4
to
55fc96e
Compare
MajorLift
changed the title
refactor: Convert selectors to TypeScript and unflatten references to
refactor: Convert selectors to TypeScript and unflatten references to Jan 7, 2025
metamask
slice (3/5)metamask
slice (3/6)
MajorLift
changed the title
refactor: Convert selectors to TypeScript and unflatten references to
refactor: Unflatten selectors and convert to TypeScript (3/6)
Jan 7, 2025
metamask
slice (3/6)Force github to recognize renames part 2 Force github to recognize renames part 3
MajorLift
force-pushed
the
jongsun/perf/redux/241206-convert-selectors-to-typescript
branch
from
January 7, 2025 18:11
1852790
to
9c931d8
Compare
27 tasks
MajorLift
changed the title
refactor: Unflatten selectors and convert to TypeScript (3/6)
refactor: Unflatten selectors and convert to TypeScript
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
DO-NOT-MERGE
Pull requests that should not be merged
team-extension-platform
team-tiger
Tiger team (for tech debt reduction + performance improvements)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Converting selectors to TypeScript is strictly speaking out-of-scope for this epic, but I decided to undertake it for these reasons:
Description
metamask
slice.state
parameter to usecreate{,DeepEqual}Selector
instead.state
type assignment with type dynamically derived from selector composition.Notes
ui/selectors
,ui/ducks
,ui/helpers/utils
,shared/modules/selectors
.ui/selectors
(excluding type imports) from 5 to 33.Related issues
metamask
Redux slice #29600reselect
to^5.1.1
for heterogeneously-typed selectors support #29094Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist