Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Next.js playground with turborepo integration #1198

Merged
merged 4 commits into from
Jan 15, 2025
Merged

Conversation

abretonc7s
Copy link
Collaborator

Description

This PR builds on #1195 to introduce a new Next.js playground package leveraging the turborepo setup.

Dependencies

⚠️ Requires PR #1195 to be merged first.

Key Changes

  • Added new playground-next package with Next.js 15.1.4
  • Basic MetaMask integration example with workspace dependencies
  • Simple wallet connection demo
  • Added package to workspace config

Benefits

  • Modern playground environment with proper hot reload
  • Direct workspace dependencies instead of transpiled references
  • Streamlined development workflow building on turborepo setup

Implementation Details

  • Next.js app setup with MetaMaskProvider
  • Basic wallet connection example
  • Proper TypeScript and ESLint configuration
  • Workspace dependency on @metamask/sdk-react

@abretonc7s abretonc7s marked this pull request as ready for review January 15, 2025 03:06
@abretonc7s abretonc7s requested a review from a team as a code owner January 15, 2025 03:06
Copy link

socket-security bot commented Jan 15, 2025

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@types/[email protected] None 0 20.6 kB types
npm/@types/[email protected] None 0 800 kB types
npm/[email protected] Transitive: environment, filesystem, unsafe +29 10.5 MB vercel-release-bot
npm/[email protected] environment, filesystem, network, shell, unsafe Transitive: eval +33 1.45 GB rauchg, timneutkens, vercel-release-bot
npm/[email protected] Transitive: environment +1 84.2 kB
npm/[email protected] None 0 0 B

View full report↗︎

Copy link

socket-security bot commented Jan 15, 2025

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/[email protected]

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.02%. Comparing base (458c3fa) to head (912d073).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1198      +/-   ##
==========================================
- Coverage   74.02%   74.02%   -0.01%     
==========================================
  Files         182      182              
  Lines        4343     4342       -1     
  Branches     1064     1064              
==========================================
- Hits         3215     3214       -1     
  Misses       1128     1128              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abretonc7s
Copy link
Collaborator Author

@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/[email protected]

chakra-guy
chakra-guy previously approved these changes Jan 15, 2025
@abretonc7s abretonc7s enabled auto-merge (squash) January 15, 2025 11:55
Copy link
Collaborator

@christopherferreira9 christopherferreira9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@chakra-guy chakra-guy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abretonc7s abretonc7s merged commit 123dd05 into main Jan 15, 2025
36 checks passed
@abretonc7s abretonc7s deleted the newnext branch January 15, 2025 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants