Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: socket server with dapp metadata #692

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Conversation

abretonc7s
Copy link
Collaborator

@abretonc7s abretonc7s commented Feb 20, 2024

Explanation

  • Release updated socket server excluding the redis adapter.
    --> This will allow to reconciliate events with appropriate metadata on the server.

References

https://app.zenhub.com/workspaces/metamask-sdk-6359297a36f20292c13feca0/issues/gh/metamask/metamask-sdk/690

Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] environment, filesystem, shell Transitive: network +6 299 kB remy

🚮 Removed packages: npm/[email protected], npm/[email protected]

View full report↗︎

Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ff12659) 79.62% compared to head (1c9309f) 79.62%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #692   +/-   ##
=======================================
  Coverage   79.62%   79.62%           
=======================================
  Files         170      170           
  Lines        3544     3544           
  Branches     1023     1023           
=======================================
  Hits         2822     2822           
  Misses        722      722           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@andreahaku andreahaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abretonc7s abretonc7s merged commit 54de93c into main Feb 20, 2024
31 checks passed
@abretonc7s abretonc7s deleted the feat/socket-server branch February 20, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants