Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: restrict rpc method analytics #755

Merged
merged 2 commits into from
Mar 12, 2024
Merged

feat: restrict rpc method analytics #755

merged 2 commits into from
Mar 12, 2024

Conversation

abretonc7s
Copy link
Collaborator

@abretonc7s abretonc7s commented Mar 12, 2024

Explanation

Limit the number of rpc calls that are tracked for analytics to the one redirecting to wallet on extension.
On mobile the list is:

  'eth_sendTransaction',
  'eth_signTypedData',
  'eth_signTransaction',
  'wallet_requestPermissions',
  'wallet_switchEthereumChain',
  'eth_signTypedData_v3',
  'eth_signTypedData_v4',
  'metamask_connectSign',
  'metamask_connectWith',
  'metamask_batch',

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@abretonc7s abretonc7s requested a review from a team as a code owner March 12, 2024 15:52
@abretonc7s abretonc7s merged commit 149f4f1 into main Mar 12, 2024
26 checks passed
@abretonc7s abretonc7s deleted the feat/rpc_mobile branch March 12, 2024 16:01
@omridan159 omridan159 mentioned this pull request Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants