Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add --option argument #317

Merged
merged 1 commit into from
Jan 20, 2025
Merged

feat: add --option argument #317

merged 1 commit into from
Jan 20, 2025

Conversation

msfjarvis
Copy link
Contributor

@msfjarvis msfjarvis commented Jan 8, 2025

Fixes #316

Tested by invoking the newly built nix-update as nix-update --option extra-experimental-features pipe-operators --commit --build on a package that uses the pipe operator and previously failed to evaluate.

nix_update/__init__.py Outdated Show resolved Hide resolved
@msfjarvis msfjarvis requested a review from Mic92 January 14, 2025 18:54
@msfjarvis msfjarvis changed the title feat: add extra-flags option feat: add --option argument Jan 15, 2025
@Mic92
Copy link
Owner

Mic92 commented Jan 19, 2025

I would prefer this syntax without the -- in front of the option:

nix-update --option extra-experimental-features pipe-operators --commit --build

Nix also has support for --option extra-experimental-features pipe-operators.

nix_update/__init__.py Outdated Show resolved Hide resolved
Fixes #316

Co-authored-by: Jörg Thalheim <[email protected]>
@Mic92
Copy link
Owner

Mic92 commented Jan 20, 2025

@mergify queue

Copy link
Contributor

mergify bot commented Jan 20, 2025

queue

☑️ The pull request will automatically be requeued

Merge queue reset: an external action moved the base branch head to cea66cb

@Mic92 Mic92 merged commit 6891656 into Mic92:main Jan 20, 2025
4 checks passed
@msfjarvis msfjarvis deleted the hs/extra-flags branch January 20, 2025 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose Options.extra_flags in nix-update CLI
2 participants