Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for Prisma 6 #476

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

FezVrasta
Copy link

@FezVrasta FezVrasta commented Dec 9, 2024

Fixes #475

@lucasrivoiro
Copy link

Please, merge this. Will help me a lot! Thz!

@gabrielbryk
Copy link

Bump

@rlecellier
Copy link

When i launch tests with [email protected] i get this results:

Test Suites: 5 failed, 15 passed, 20 total
Tests:       29 failed, 135 passed, 164 total
Snapshots:   39 failed, 20 obsolete, 461 passed, 500 total
Time:        63.238 s

I would like to have this merge too, but i don't think that's possible as is.

@MichalLytek
Copy link
Owner

@rlecellier
You're right, upgrading to new a Prisma version, especially major release, is not as simple as bumping dependency.

Tests need to be passing green. Most of them are snapshot-based. So the one who upgrades (maintainer/contributor) has to examine the reported snapshots differences and decides if they are matching expectation (like when Prisma changed to findOrThrow API) and only then update the snapshots. Sometimes some changes around DMMF parsing are required to properly translate it into the format used by the class generator, so we keep emitting fields and types properly, are not missing new methods, etc.

If someone is willing to spend more time on updating this tool to new Prisma release, I'm happy to colaborate, answer question or guide how to achieve something in the code.

@FezVrasta
Copy link
Author

FYI I have been using this patch on a production app for months with zero issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Prisma 6
5 participants