Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sample-single-page-app-vanillajs-sign-in.md #1113

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

samuelschnurr
Copy link

The part of the documentation is misleading. In the previous chapter you are told to create the path localhost:3000 as a redirect in the app registration. However, the cloned repository points to the path localhost:3000/redirect by default.

This PR adds an information that if you want to use the configured url (localhost:3000), you also have to delete the property in the repository so that the default value is used.

This information was previously missing in the list of adjustments to be made.

Copy link
Contributor

@samuelschnurr : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit 1788467:

✅ Validation status: passed

File Status Preview URL Details
docs/external-id/customers/sample-single-page-app-vanillajs-sign-in.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@Court72
Copy link
Contributor

Court72 commented Aug 29, 2024

@OwenRichards1

Can you review the proposed changes?

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

Copy link

This pull request has been inactive for 90 days. If you are finished with your changes, don't forget to sign off. See the contributor guide for instructions.

If this PR is inactive for 1 more day, it will be closed automatically. Thank you!

Microsoft Entra Content Team Contact Us

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants