Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preprocesser for anime face segment #2212

Merged
merged 17 commits into from
Nov 3, 2023

Conversation

sdbds
Copy link
Collaborator

@sdbds sdbds commented Nov 1, 2023

#2127
match this model

bdsqlsz_controllllite_xl_segment_animeface_V2

COLOR_BACKGROUND = (255,255,0)
COLOR_HAIR = (0,0,255)
COLOR_EYE = (255,0,0)
COLOR_MOUTH = (255,255,255)
COLOR_FACE = (0,255,0)
COLOR_SKIN = (0,255,255)
COLOR_CLOTHES = (255,0,255)

@sdbds
Copy link
Collaborator Author

sdbds commented Nov 1, 2023

image

I tested ,it works well

@sdbds sdbds marked this pull request as ready for review November 1, 2023 19:03
@lllyasviel
Copy link
Collaborator

hello, are you interested in join repo collaboration with writing permission?
please let me know if yes, and u will help maintain this part of this pr and other lllite related codes.

@sdbds
Copy link
Collaborator Author

sdbds commented Nov 2, 2023

hello, are you interested in join repo collaboration with writing permission? please let me know if yes, and u will help maintain this part of this pr and other lllite related codes.

Thank you for your invitation and trust, I am also happy to contribute to the controlnet community.
In the past month, I have been testing the training of controlnet lllite for almost SD1.5 version.
I have also been contributing to kohya's sd-scripts all along.

@lllyasviel
Copy link
Collaborator

ok @huchenlei @ljleb if you have other ideas then let me know now or just as is.
I am emailing @Mikubill for final approval

@huchenlei
Copy link
Collaborator

LGTM on the PR.

Welcome @sdbds joining the ControlNet extension dev 🎉

Copy link
Collaborator

@ljleb ljleb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not ran the code but it otherwise looks good. I don't think my opinion matters as to who should or shouldn't be a Collaborator.

@lllyasviel
Copy link
Collaborator

@sdbds welcome to sd-webui-controlnet

and make sure to test that everything works (at least, test canny/depth/openpose on SD1.5, no matter whether you have changed them or not) before merging codes

@sdbds
Copy link
Collaborator Author

sdbds commented Nov 3, 2023

@sdbds welcome to sd-webui-controlnet

and make sure to test that everything works (at least, test canny/depth/openpose on SD1.5, no matter whether you have changed them or not) before merging codes

i got it.
i tested all SD1.5 controlnet, it works well.
i will merged this into dev branch.

@sdbds sdbds merged commit 511e42a into Mikubill:dev Nov 3, 2023
1 check failed
@huchenlei
Copy link
Collaborator

Just one thing to mention about merging. @sdbds
We normally use "squash and merge" instead of direct merge to keep the commit history clean.

@huchenlei huchenlei mentioned this pull request Nov 22, 2023
@sdbds sdbds deleted the add_anime_face_segment branch May 11, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants