Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Bounding Box Code #37

Open
OrangePear13 opened this issue Nov 6, 2024 · 2 comments · May be fixed by #42
Open

Refactor Bounding Box Code #37

OrangePear13 opened this issue Nov 6, 2024 · 2 comments · May be fixed by #42
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers vision Vision subteam / works with computer vision to interact with photos and identify important objects

Comments

@OrangePear13
Copy link

Refactor Bounding Box Code

Problem

The Bounding Box code in vision/common/bounding_box.py needs to be refactored to reduce complexity and remove unnecessary features.

Solution

The refactored bounding_box.py should:

  • not have setter and getter functions
    • unnecessary for our use case
  • not have an ObjectType
    • no longer needed (also remove the Enum)
  • not have an attributes dictionary
    • largely unnecessary and should be implemented seperately if needed
  • Store coordinates as a top left corner position, width, and height
    • NOTE: Tentative, further discussion needed
@OrangePear13 OrangePear13 added enhancement New feature or request good first issue Good for newcomers vision Vision subteam / works with computer vision to interact with photos and identify important objects labels Nov 6, 2024
@J-The-Fox
Copy link
Member

Does anything need to be done with the tlwh_to_vertices function as well or can that be left how it is?

@OrangePear13
Copy link
Author

I think it should be fine as is, at least for now.
It might become redundant if we convert the bounding box representation to the format of storing one corner coordinate along with a width and length. But, I still haven't decided if that would be a good idea, as I'm not yet sure if we will need support for rotated boxes, TBD.

@J-The-Fox J-The-Fox self-assigned this Nov 13, 2024
@J-The-Fox J-The-Fox linked a pull request Nov 15, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers vision Vision subteam / works with computer vision to interact with photos and identify important objects
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants