-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring bounding_box.py #42
base: develop
Are you sure you want to change the base?
Conversation
Looks like some other files may need to be updated before this can go through? As it seems that some of these were used by other files that pre-commit didn't catch during the commit itself (Like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to go! Nice work
Just the pre-commit errors in |
Ah alright, so those would be updated separate then? |
Yeah, I will take a look at the other files. Given that other people currently are changing those as well, I will coordinate with them to make necessary adjustments. |
closes #37
Refactoring bounding_box.py
A refactor for
bounding_box.py
Changes
ObjectType
class__repr__
method fromBoundingBox
classverticies
properties (both setter and getter) fromBoundingBox
classobj_type
properties (both setter and getter) fromBoundingBox
classattributes
properties (both setter and getter) fromBoundingBox
classset_attribute
method fromBoundingBox
classget_attribute
method fromBoundingBox
classget_rotation_angle
method fromBoundingBox
classget_tlwh
method fromBoundingBox
classBoundingBox
class parameters fromverticies
,obj_type
, andattributes
totop_left
,width
, andheight
__init__
method forBoundingBox
class to reflect updated parametersBoundingBox
class to reflect updated parametersBoundingBox
classBoundingBox
classAdditional Notes
Some of the methods can be further refactored to not use 4 verticies. However, I left them as such to not have to redo the math that goes into them. If need be, I can update those methods as well.