Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update Gradle to 8.2 and AGP to 8.2.0 #149

Closed
wants to merge 1 commit into from

Conversation

thearaks
Copy link

Please accept this pull request and release a new version of the library since it's blocking compilation with Flutter 3.16.
Thank you!

@MisterJimson
Copy link
Owner

Looking at this. In the mean time can you see if 6.0.0-beta solves your problem as well? Ideally the library works for Gradle 7 and 8.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8c28373) 76.53% compared to head (fab1b88) 76.53%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #149   +/-   ##
=======================================
  Coverage   76.53%   76.53%           
=======================================
  Files           6        6           
  Lines          98       98           
=======================================
  Hits           75       75           
  Misses         23       23           

@MisterJimson
Copy link
Owner

I've just tested 6.0.0-beta on a fresh counter app created with Flutter 3.16.4 so I'm hoping this isn't needed?

@thearaks
Copy link
Author

Hi @MisterJimson,
Gradle 7 is probably enough for Flutter 3.16 but Gradle 8.0+ is needed with the latest versions of Android Studio and for every app that includes at least a plugin that's been migrated to Gradle 8.0+ and requires the new build scripts syntax/features.

I'd release a new version with Gradle 8.0+ since every app is being migrated to the newest Gradle versions and I think that Flutter soon will move to 8.0+ as "default" Gradle version.

At the moment I have to use my forked version since I cannot include this plugin in my app that's using Gradle 8.0+ (and I can't downgrade it since other plugins requires 8.0+).

@MisterJimson
Copy link
Owner

Hmm. I tested with Android Studio 2023.1.1 and it worked for me. I'll look into it deeper.

Just to be clear, did you test your app with 6.0.0-beta that was published yesterday?

@thearaks
Copy link
Author

Hi @MisterJimson, sorry for this late update, I've been busy with some other work projects.
I've run a test build with version 6.0.0-beta in an app that's using Gradle 8.2 and the build completed successfully!

@MisterJimson
Copy link
Owner

Thank you! I'll close this PR for now and will likely reopen when Gradle 8 is mandatory or Gradle 7 is fully deprecated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants