Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS - Added Privacy Manifests #153

Conversation

martin-headspace
Copy link

Summary

Added an empty Privacy Manifest to the iOS project in preparation for the May 1st Deadline for 3rd Party SDKs that include native iOS code.

Description

Starting May 1: You’ll need to include approved reasons for the listed APIs used by your app’s code to upload a new or updated app to App Store Connect.
...
Make sure to use a version of the SDK that includes its privacy manifest and note that signatures are also required when the SDK is added as a binary dependency.

Privacy updates for App Store submissions - Latest News - Apple Developer
Upcoming third-party SDK requirements - Support - Apple Developer

Impact and Testing

Developers using an updated version of this library on their iOS projects shouldn't see any issues related to the Privacy Manifest

Contributor Note

Based on the language on Apple's Website, this change seems to be mandatory for all 3rd Party Libraries. The impact of not adding it is unclear to me, but hopefully having it will be better than not.

@ceeyang
Copy link

ceeyang commented Apr 17, 2024

Hello sir,
Thanks very much for your Pull Request.
How can I use your focked repository for my project.

# This is ok
flutter_timezone:
  git:
    ref: chore/add-privacy-manifest
    url: https://github.com/martin-headspace/flutter_timezone.git

# This is wrong
flutter_keyboard_visibility:
  git:
    ref: chore/update-privacy-manifest
    url: https://github.com/martin-headspace/flutter_keyboard_visibility.git  #This url is not work

How should I fill in the correct url address and point to the flutter_keyboard_visibility path.

Of course, when this Pull Request is merged, there is no need to be so troublesome.

@martin-headspace
Copy link
Author

martin-headspace commented Apr 17, 2024

Hello sir, Thanks very much for your Pull Request. How can I use your focked repository for my project.

# This is ok
flutter_timezone:
  git:
    ref: chore/add-privacy-manifest
    url: https://github.com/martin-headspace/flutter_timezone.git

# This is wrong
flutter_keyboard_visibility:
  git:
    ref: chore/update-privacy-manifest
    url: https://github.com/martin-headspace/flutter_keyboard_visibility.git  #This url is not work

How should I fill in the correct url address and point to the flutter_keyboard_visibility path.

Of course, when this Pull Request is merged, there is no need to be so troublesome.

Hey @ceeyang ,
You can try using:

flutter_keyboard_visibility:
  git:
    ref: chore/update-privacy-manifest
    url: https://github.com/martin-headspace/flutter_keyboard_visibility.git
    path: flutter_keyboard_visibility

@ceeyang
Copy link

ceeyang commented Apr 18, 2024

Hello sir, Thanks very much for your Pull Request. How can I use your focked repository for my project.

# This is ok
flutter_timezone:
  git:
    ref: chore/add-privacy-manifest
    url: https://github.com/martin-headspace/flutter_timezone.git

# This is wrong
flutter_keyboard_visibility:
  git:
    ref: chore/update-privacy-manifest
    url: https://github.com/martin-headspace/flutter_keyboard_visibility.git  #This url is not work

How should I fill in the correct url address and point to the flutter_keyboard_visibility path.
Of course, when this Pull Request is merged, there is no need to be so troublesome.

Hey @ceeyang , You can try using:

flutter_keyboard_visibility:
  git:
    ref: chore/update-privacy-manifest
    url: https://github.com/martin-headspace/flutter_keyboard_visibility.git
    path: flutter_keyboard_visibility

Thanks very much, I got it.

@Abeansits
Copy link

@MisterJimson the Apple requirement for privacy manifests is taking effect from tomorrow, if you're happy with this PR can we please merge it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants