Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ✨ remove file deletion requests expiration #311

Open
wants to merge 12 commits into
base: feat/enforce-file-deletion-msps
Choose a base branch
from

Conversation

TDemeco
Copy link
Contributor

@TDemeco TDemeco commented Jan 7, 2025

This PR makes it so file deletion requests no longer expire. This is possible since MSPs are now incentivized to submit the required proofs to close the pending file deletion requests because they are removed from the privileged providers in the meantime, so they can't charge any users.
This PR should be merged after #310

TODO list:

  • Keep track of how many pending file deletion requests a MSP has and add it to the privileged providers storage only if it has submitted a proof for the last one remaining.
  • Check if incentives are aligned correctly in terms of avoiding MSPs being spammed by malicious users with file deletion requests.

@TDemeco TDemeco requested review from ffarall and snowmead January 7, 2025 20:48
@TDemeco TDemeco marked this pull request as ready for review January 7, 2025 21:15
@TDemeco TDemeco changed the base branch from main to feat/enforce-file-deletion-msps January 7, 2025 21:18
Copy link
Contributor

@snowmead snowmead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love seeing all the deleted complexity

@ffarall
Copy link
Contributor

ffarall commented Jan 9, 2025

@TDemeco Regarding the soundness of incentives to prevent spamming with file deletions, I can think of two mitigations:

  1. Only allowing file deletions for buckets that we can check that exist. This one we should implement for sure. It's free and gives us some better guarantees, as the MSP could only be spammed by users from whom it accepted storing buckets.
  2. Requiring a deposit from the user to delete a file, that would be released if the MSP responds with an inclusion proof (i.e. the file exists). But if the MSP responds with an non-inclusion proof (the file doesn't exist), the deposit goes to the MSP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants