Wallabag integration #185
Closed
Wallabag integration #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Mosc <[email protected]>
Co-authored-by: Mosc <[email protected]>
This reverts commit a6e9203.
|
I appreciate the effort, but I have issues with including such a tight integration with a service that's not directly related to Hacker News, and which I don't make use of myself and therefore will not be able to put effort into maintaining. Obviously wallabag's open-source nature helps, but I would still prefer a more generic solution. |
|
No worries, Ill be maintaining it as a fork then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the possibility to add articles to a Wallabag instance.
This PR supersedes #106
This PR is based on #110
Changes:
Added Wallabag API Service
Added Credential Form in Settings (with persistence + validation)
"Add to Wallabag" underneath every "Share"-Action (with same conditions), when valid credentials provided
Wallabag Dialog: