Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect subscribed in backend #784

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Detect subscribed in backend #784

merged 1 commit into from
Nov 8, 2023

Conversation

benthecarman
Copy link
Collaborator

@benthecarman benthecarman commented Oct 2, 2023 •
edited
Loading

Detects if subscribed and will save nwc profiles to vss if you have mutiny+

@benthecarman benthecarman force-pushed the detect-subscribed branch 2 times, most recently from 7e9da3b to b41df96 Compare October 2, 2023 03:37
@benalleng
Copy link
Collaborator

Will this remove the need for the frontend to store sub-status in localStorage?

@benthecarman
Copy link
Collaborator Author

Will this remove the need for the frontend to store sub-status in localStorage?

It should, I need to expose it as a function first, will add

@TonyGiorgio
Copy link
Contributor

We currently give a 3 day grace period if the user was offline.

Is NWC profiles being saved for everyone now or just those being subscribed?

@benthecarman
Copy link
Collaborator Author

Is NWC profiles being saved for everyone now or just those being subscribed?

just subscribed

@TonyGiorgio
Copy link
Contributor

What's going to happen to people that stopped subscribing? Is their data going to be deleted? How is it fetched when they stopped subscribing?

@TonyGiorgio
Copy link
Contributor

I just really don't want to see anything stored in VSS besides critical data until we have a better handle on storage stuff.

@benthecarman
Copy link
Collaborator Author

I just really don't want to see anything stored in VSS besides critical data until we have a better handle on storage stuff.

yeah i understand that, this should handle all the cases but we can leave it out for now

@benthecarman benthecarman force-pushed the detect-subscribed branch 2 times, most recently from fa39864 to 92f4da0 Compare November 7, 2023 21:16
@TonyGiorgio TonyGiorgio merged commit 0214f3f into master Nov 8, 2023
9 checks passed
@TonyGiorgio TonyGiorgio deleted the detect-subscribed branch November 8, 2023 04:13
@benthecarman benthecarman mentioned this pull request Nov 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TonyGiorgio TonyGiorgio TonyGiorgio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benthecarman @benalleng @TonyGiorgio