-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements to startup speed #787
Conversation
136ea06
to
8ab4e36
Compare
8ab4e36
to
dab7a8a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any tests here. Last time we changed encryption stuff it ended badly.
Added a test for a different mnemonic, needed to remove the panic and just change to an error, otherwise couldnt test it properly Our other tests handled all the other cases |
Okay that looks good. Last thought, I was revisiting some of this with this pr: #752 Is that something we'd want to do? I dont know if we want to attempt to remove some of the cipher re-initializations, but this PR does fix some of the investigations I was looking through when I was attempting it again. Namely, the double storage init. |
Yeah I think the idea of that is good, probably good for a follow up. I think this handles it so we aren't doing anything inefficiently now but the API isn't as clean as it could be with that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, sorry it took awhile. Needed to grok it again.
With the service worker / push notification stuff I imagine we'll need to get our startup time faster. This is one step towards that.
This changes so we don't read all of storage an extra time just to get our seed for vss.
Found a couple clean ups to go along with this