Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start on nix flakes #802

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Start on nix flakes #802

merged 1 commit into from
Oct 30, 2023

Conversation

TonyGiorgio
Copy link
Contributor

No description provided.

Comment on lines -4 to -5
./*/Cargo.lock
Cargo.lock
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we still want these to be ignored, since this is a library

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It shouldn't hurt anything to have it and the rust lock file recommendations have changed

@TonyGiorgio
Copy link
Contributor Author

I'll rebase after the tests pass but essentially this is ready

Use rust-overlay as the flake type
Copy link
Collaborator

@benthecarman benthecarman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for me to get it to work i have to change aarch64-unknown-linux-gnu to x86_64-unknown-linux-gnu, not sure if we can have it detect, but this is fine for now!

Maybe just add a note that nix only works for aarch64 in the readme

@TonyGiorgio TonyGiorgio merged commit e926b9e into master Oct 30, 2023
9 checks passed
@TonyGiorgio TonyGiorgio deleted the nix-flake branch October 30, 2023 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants