Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

export npub to hexpub function #812

Merged
merged 1 commit into from
Oct 28, 2023
Merged

export npub to hexpub function #812

merged 1 commit into from
Oct 28, 2023
+8 −1

Conversation

futurepaul
Copy link
Contributor

this one function can get rid of our entire nostr dep on the frontend, which is a decent size saving: https://bundlephobia.com/package/@nostr-dev-kit/[email protected]

@futurepaul futurepaul mentioned this pull request Oct 28, 2023
Merged
TonyGiorgio
TonyGiorgio approved these changes Oct 28, 2023
View reviewed changes
Copy link
Contributor

@TonyGiorgio TonyGiorgio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Eventually we may want a place to stick static helper functions but for now this is fine.

@futurepaul futurepaul merged commit c6e7576 into master Oct 28, 2023
@futurepaul futurepaul deleted the npub-to-hexpub branch October 28, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TonyGiorgio TonyGiorgio TonyGiorgio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@futurepaul @TonyGiorgio