Nostr Wallet Auth #815
Merged
Nostr Wallet Auth #815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benthecarman
force-pushed
the
nostr-wallet-auth
branch
from
8726f85 to
29bcf8d
Compare
benthecarman
force-pushed
the
nostr-wallet-auth
branch
5 times, most recently
from
74db79b to
9ade646
Compare
|
Have this end-to-end working with zapple pay |
TonyGiorgio
requested changes
Nov 20, 2023
mutiny-wasm/src/lib.rs
Outdated
| let profile = self | ||
| .inner | ||
| .nostr | ||
| .approve_nostr_wallet_auth(ProfileType::Normal { name }, uri, NwcProfileTag::General) |
There was a problem hiding this comment.
might as well remove type from this request if it's only going to be used for Normal
There was a problem hiding this comment.
We may want to use approve_nostr_wallet_auth with other profile types in the future, think it is better to have the type. Also lets us reuse the same logic for other NWCs
benthecarman
force-pushed
the
nostr-wallet-auth
branch
3 times, most recently
from
2dbb486 to
2310f01
Compare
|
Responded to review and added a test (which caught a bug :) ) |
benthecarman
force-pushed
the
nostr-wallet-auth
branch
from
6e012f6 to
2581a33
Compare
benthecarman
force-pushed
the
nostr-wallet-auth
branch
from
2581a33 to
b5ca81a
Compare
benthecarman
force-pushed
the
nostr-wallet-auth
branch
from
b5ca81a to
8b1ba44
Compare
2 tasks
benthecarman
force-pushed
the
nostr-wallet-auth
branch
from
a1228b5 to
7752e58
Compare
TonyGiorgio
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nostr-protocol/nips#851