Update wasm bindgen #821
Merged
Update wasm bindgen #821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How does this look on the typescript side? Would it be straightfoward enough to implement? @futurepaul ? |
|
conceptually it sounds like a win, although in but when I switch to this branch I get some panics... 
|
|
We're not running lightning 117 anymore. Are you correctly updating? |
benthecarman
force-pushed
the
update-wasm-bindgen
branch
2 times, most recently
from
d3ac033 to
87226be
Compare
futurepaul
approved these changes
Nov 10, 2023
There was a problem hiding this comment.
re-tested this and it's actually very helpful (more types in the frontend!). idk what I was doing wrong before. here's a frontend PR against this: MutinyWallet/mutiny-web#691
benthecarman
force-pushed
the
update-wasm-bindgen
branch
from
87226be to
99d38c5
Compare
TonyGiorgio
approved these changes
Nov 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New wasm-bindgen supports sending
Vec<T>for non-async functions. Tried to implement that everywhere we can.