Give InsufficientBalance before trying to send #827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TonyGiorgio
reviewed
Nov 5, 2023
| < send_msats | ||
| { | ||
| // Channels exist but not enough capacity | ||
| return Err(MutinyError::InsufficientBalance); |
There was a problem hiding this comment.
This could be confusing if the user has some channels and balance but the connection to the LSP node is not currently active.
There was a problem hiding this comment.
This handles that, is channel ready, only checks if it's been confirmed, not if they have an active connection.
There was a problem hiding this comment.
Ohh okay. Then it sounds like it is much better then but doesn't quite resolve the LSP disconnection problem, but I think that's what the UI designs for disconnections will have to fix.
TonyGiorgio
approved these changes
Nov 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #816
Before if we had a confirming channel we would still try to send and give a RouteNotFound error which could be confusing.
This fixes by first summing up the balance of our confirmed channels and seeing if we have enough balance.
We can remove the
is_emptycheck because that will sum to0