Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for 0 reserve in channels #831

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Allow for 0 reserve in channels #831

merged 1 commit into from
Nov 7, 2023

Conversation

benthecarman
Copy link
Collaborator

@benthecarman benthecarman commented Nov 7, 2023

I dont think this will let the user have 0 reserve but it will at least give them slightly more inbound from the LSP not having any reserve

@TonyGiorgio
Copy link
Contributor

Is 0 an allowed value? I think above dust is still required.

@benthecarman
Copy link
Collaborator Author

benthecarman commented Nov 7, 2023

it says

If the calculated proportional value is less than 1000 sats, it will be treated as 1000 sats instead, which is a safe implementation-specific lower bound

So this will enforce that it doesn't error with dust

@TonyGiorgio TonyGiorgio merged commit c309c1a into master Nov 7, 2023
9 checks passed
@TonyGiorgio TonyGiorgio deleted the 0-reserve branch November 7, 2023 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants