Restore returning the subscription expire time instead of bool #839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TonyGiorgio
approved these changes
Nov 9, 2023
TonyGiorgio
reviewed
Nov 9, 2023
| Ok(MutinyWallet { | ||
| mnemonic, | ||
| inner, | ||
| subscription_expire_time: sub_expired_time, |
There was a problem hiding this comment.
really? that's such a hack
There was a problem hiding this comment.
not sure a better place to put it, maybe the config?
There was a problem hiding this comment.
Honestly I was fine with the old way of doing it. Now I'm questioning if you've covered every edge case paul was doing in the frontend previously.
There was a problem hiding this comment.
Where do you update this when the user subscribes?
There was a problem hiding this comment.
Honestly I would rather revert the subscription changes at this point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
small fix so we can display when the next mutiny+ invoice is