Fix bug with file extension checks on products #1112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 14, 2025 10:27
added 5 commits
January 14, 2025 12:06
Seems the catalog is messed up and some strange things happening with schema/schematron on PDS.
|
nutjob4life
approved these changes
Jan 14, 2025
There was a problem hiding this comment.
Visual inspection: ✓
Tests: ✓
Transcript:
[INFO] Tests run: 236, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 614.7 s -- in cucumber.CucumberTest
[INFO]
[INFO] Results:
[INFO]
[WARNING] Tests run: 259, Failures: 0, Errors: 0, Skipped: 23
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 10:49 min
[INFO] Finished at: 2025-01-14T15:55:00-06:00
[INFO] ------------------------------------------------------------------------
|
I want to merge this so that I can incorporate it into #1113 to smooth out cucumber. Can you review/merge it please? |
jordanpadams
approved these changes
Jan 16, 2025
jordanpadams
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Summary
Validate moved away from checking extensions and checks content instead. Bad code was left in place that erroneously checked the extension of the file causing this problem. Removed offending code.
⚙️ Test Data and/or Report
All unit tests below pass especially the new one github1100.
♻️ Related Issues
Closes #1100
Closes #1103