-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes ASV version pin and pin Conda version for ASV workflow #610
Conversation
This changes from micromamba to miniconda so that we can easily set the conda version to avoid the current ASV failure. It looks like we can do environment caching w/ miniconda now too though it's a bit clunkier I think and I haven't implemented that yet. It also unpins the ASV version since the new one works and moves that install from pip to conda since that's now an option. See here for an example workflow run: https://github.com/kafitzgerald/geocat-comp/actions/runs/8898705224/job/24436440204 |
Caching packages rather than envs didn't really help to the same degree so I went back and set up env caching. It's a good bit more verbose than with the micromamba action, but it gets the job done for now and we can switch back later if desired. Should be good to go now hopefully. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, thanks for fixing this!
PR Summary
Removes ASV version pin and pin micromamba version for ASV workflow
Closes #555
Closes #607 (though we should log another issue or keep this open until we can unpin conda)
PR Checklist
General
closes #XXX
to the PR description where XXX is the number of the issue.docs/release-notes.rst
in a relevant section for the next unreleased release. Possible sections include: Documentation, New Features, Bug Fixes, Internal Changes, Breaking Changes/Deprecatedprecommit
. To set up on your local, runpre-commit install
from the top level of the repository. To manually run pre-commits, usepre-commit run --all-files
and re-add any changed files before committing again and pushing.