Skip to content

Commit

Permalink
Address review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
boulderdaze committed Aug 7, 2024
1 parent b30c733 commit d41d152
Show file tree
Hide file tree
Showing 13 changed files with 13 additions and 17 deletions.
2 changes: 1 addition & 1 deletion cmake/dependencies.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ if (MUSICA_ENABLE_TUVX AND MUSICA_BUILD_C_CXX_INTERFACE)
set(TUVX_INSTALL_INCLUDE_DIR ${MUSICA_INSTALL_INCLUDE_DIR} CACHE STRING "" FORCE)

set_git_default(TUVX_GIT_REPOSITORY https://github.com/NCAR/tuv-x.git)
set_git_default(TUVX_GIT_TAG f8ae5a2)
set_git_default(TUVX_GIT_TAG 0e27463)

FetchContent_Declare(tuvx
GIT_REPOSITORY ${TUVX_GIT_REPOSITORY}
Expand Down
1 change: 0 additions & 1 deletion docker/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ RUN dnf -y update \
gfortran \
gdb \
git \
# lapack-devel \
lcov \
make \
netcdf-fortran-devel \
Expand Down
1 change: 0 additions & 1 deletion docker/Dockerfile.fortran-gcc
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ RUN dnf -y update \
git \
hdf5-devel \
json-devel \
# lapack-devel \
lcov \
libcurl-devel \
m4 \
Expand Down
1 change: 0 additions & 1 deletion docker/Dockerfile.fortran-gcc.integration
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ RUN dnf -y update \
git \
hdf5-devel \
json-devel \
# lapack-devel \
lcov \
libcurl-devel \
m4 \
Expand Down
1 change: 0 additions & 1 deletion docker/Dockerfile.memcheck
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ RUN dnf -y update \
gfortran \
gdb \
git \
# lapack-devel \
lcov \
make \
netcdf-fortran-devel \
Expand Down
1 change: 0 additions & 1 deletion docker/Dockerfile.mpi
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ RUN sudo dnf -y install \
gcc-c++ \
gfortran \
git \
# lapack-devel \
lcov \
make \
netcdf-fortran-devel \
Expand Down
1 change: 0 additions & 1 deletion docker/Dockerfile.mpi_openmp
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ RUN sudo dnf -y install \
gcc-c++ \
gfortran \
git \
# lapack-devel \
lcov \
make \
netcdf-fortran-devel \
Expand Down
1 change: 0 additions & 1 deletion docker/Dockerfile.openmp
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ RUN sudo dnf -y install \
gcc-c++ \
gfortran \
git \
# lapack-devel \
lcov \
make \
netcdf-fortran-devel \
Expand Down
1 change: 0 additions & 1 deletion docker/Dockerfile.python
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ RUN dnf -y update \
gcc-fortran \
gdb \
git \
# lapack-devel \
make \
netcdf-fortran-devel \
pip \
Expand Down
5 changes: 3 additions & 2 deletions include/musica/tuvx/grid.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,10 @@ namespace musica
class Profile;
class Radiator;

/// @brief A grid struct used to access grid information in tuvx
struct Grid
/// @brief A grid class used to access grid information in tuvx
class Grid
{
public:
/// @brief Creates a grid instance
/// @param grid_name The name of the grid
/// @param units The units of the grid
Expand Down
5 changes: 3 additions & 2 deletions include/musica/tuvx/grid_map.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,10 @@
namespace musica
{

/// @brief A grid map struct used to access grid information in tuvx
struct GridMap
/// @brief A grid map class used to access grid information in tuvx
class GridMap
{
public:
GridMap(void *grid_map)
: grid_map_(grid_map),
owns_grid_map_(false)
Expand Down
5 changes: 3 additions & 2 deletions include/musica/tuvx/profile.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,10 @@ namespace musica
{
class ProfileMap;

/// @brief A struct used to interact with TUV-x profiles (properties with values on a grid)
struct Profile
/// @brief A class used to interact with TUV-x profiles (properties with values on a grid)
class Profile
{
public:
/// @brief Creates a profile instance
/// @param profile_name The name of the profile
/// @param units The units of the profile
Expand Down
5 changes: 3 additions & 2 deletions include/musica/tuvx/profile_map.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,10 @@
namespace musica
{

/// @brief A struct used to store a collection of profiles
struct ProfileMap
/// @brief A class used to store a collection of profiles
class ProfileMap
{
public:
ProfileMap(void *profile_map)
: profile_map_(profile_map),
owns_profile_map_(false)
Expand Down

0 comments on commit d41d152

Please sign in to comment.