Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hides the Sessions in javascript rather than html #33

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

claytron5000
Copy link
Collaborator

No description provided.

@claytron5000
Copy link
Collaborator Author

The goal here is to allow html modifications on both the dev.html page and the index page without having to track the hidden Sessions html. Basically, Sessions don't show without being on /dev.html. Go-live #2 will have to change this.

@rick02840
Copy link
Contributor

rick02840 commented Jan 18, 2020

Hi Clayton,

I implemented your "hide sessions with JS" fix by adding this:

// Call to function with anonymous callback
loadJSON(function (response) {
    //  COMMENT THIS OUT TO GO LIVE WITH SESSIONS
    if (!window.location.href.includes("dev.html")) {
        $(".timeslots").remove();
        return null;
    }

...which I saw in you PR (could not simply merge as too many conflicts).

These display for a second and go away: https://nerdsummit.org/#sessions

FRIDAY MARCH 20
SATURDAY MARCH 21

Not a big deal and maybe not worth fixing but if any ideas let me know -- CSS hide then JS show?

Thanks!

Rick

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants