Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: filter addresses and name for phishing #20

Closed
wants to merge 2 commits into from

Conversation

0xNumlock
Copy link

image

The NFTX JS Api was returning scam/phishing tokens - this PR filters them out as per the lists taken from https://github.com/scamsniffer/scam-database

Copy link
Collaborator

@jackmellis jackmellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A slight issue with this is fetchUserCollections isn't the only source of collection data - in fact I'm not sure if it's even being used in v3 now!

Currently the API is actually getting the list of collections from the ERC721/ERC1155 subgraphs and then pulling/caching the metadata for each one from reservoir (potentially not the most efficient method but a problem for another day), and sometimes it's getting the list of collections by just checking the vault, sometimes it's being given a list of addresses and cross referencing with what vaults there are, etc.

I think the filtering should either happen just in the api repo here: https://github.com/NFTX-project/nftx-api/blob/a6e18a88f22054b8ca6554ff5b84e38ebbeba519/src/application/collections/getCollections.ts#L97 or in both (which would require exposing the list of 0x/domains somewhere for both to consume)

@0xNumlock 0xNumlock closed this Apr 2, 2024
@0xNumlock
Copy link
Author

A slight issue with this is fetchUserCollections isn't the only source of collection data - in fact I'm not sure if it's even being used in v3 now!

Currently the API is actually getting the list of collections from the ERC721/ERC1155 subgraphs and then pulling/caching the metadata for each one from reservoir (potentially not the most efficient method but a problem for another day), and sometimes it's getting the list of collections by just checking the vault, sometimes it's being given a list of addresses and cross referencing with what vaults there are, etc.

I think the filtering should either happen just in the api repo here: https://github.com/NFTX-project/nftx-api/blob/a6e18a88f22054b8ca6554ff5b84e38ebbeba519/src/application/collections/getCollections.ts#L97 or in both (which would require exposing the list of 0x/domains somewhere for both to consume)

https://github.com/NFTX-project/nftx-api/pull/20

@0xNumlock 0xNumlock deleted the feat-filter-phishing-tokens branch April 2, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants