Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend cat builder #547

Merged

Conversation

wrongkindofdoctor
Copy link
Collaborator

Description

  • add entries to GFDL and CMIP fieldlists
  • add custom parser for AM5 data to catalog builder
  • add optional config file parameter to set the desired catalog parser

Associated issue # (replace this phrase and parentheses with the issue number)

How Has This Been Tested?
Please describe the tests that you ran to verify your changes in enough detail that
someone can reproduce them. Include any relevant details for your test configuration
such as the Python version, package versions, expected POD wallclock time, and the
operating system(s) you ran your tests on.

Checklist:

  • My branch is up-to-date with the NOAA-GFDL main branch, and all merge conflicts are resolved
  • The scripts are written in Python 3.11 or above (preferred; required if funded by a CPO grant), NCL, or R
  • All of my scripts are in the diagnostics/[POD short name] subdirectory, and include a main_driver script, template html, and settings.jsonc file
  • I have made corresponding changes to the documentation in the POD's doc/ subdirectory
  • I have requested that the framework developers add packages required by my POD to the python3, NCL, or R environment yaml file if necessary, and my environment builds with conda_env_setup.sh
  • I have added any necessary data to input_data/obs_data/[pod short name] and/or input_data/model/[pod short name]
  • My code is portable; it uses MDTF environment variables, and does not contain hard-coded file or directory paths
  • I have provided the code to generate digested data files from raw data files
  • Each digested data file generated by the script contains numerical data (no figures), and is 3 GB or less in size
  • I have included copies of the figures generated by the POD in the pull request
  • The repository contains no extra test scripts or data files

@wrongkindofdoctor wrongkindofdoctor added the tool Scripts or features that assist with data or code management that are not part of the framework src label Apr 23, 2024
@wrongkindofdoctor wrongkindofdoctor self-assigned this Apr 23, 2024
@wrongkindofdoctor wrongkindofdoctor merged commit 5704078 into NOAA-GFDL:main Apr 23, 2024
2 of 4 checks passed
# split the file name into components based on
# assume am5 file name format is {realm}.{time_range}.[variable_id}.nc
split = stem.split('.')
num_file_parts = len(split)

Check notice

Code scanning / CodeQL

Unused local variable Note

Variable num_file_parts is not used.
@@ -21,21 +21,26 @@
import traceback
import typing
import xarray as xr
import json

Check notice

Code scanning / CodeQL

Unused import Note

Import of 'json' is not used.
@wrongkindofdoctor wrongkindofdoctor deleted the extend_cat_builder branch May 1, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tool Scripts or features that assist with data or code management that are not part of the framework src
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant