Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small fix #729

Merged
merged 1 commit into from
Jan 10, 2025
Merged

small fix #729

merged 1 commit into from
Jan 10, 2025

Conversation

bitterbark
Copy link
Collaborator

The catalog parser wouldn't run for me without this small change.

How Has This Been Tested?
Run on CESM data, NCAR's casper machine

Checklist:

  • [x ] My branch is up-to-date with the NOAA-GFDL main branch, and all merge conflicts are resolved
  • [x ] The scripts are written in Python 3.12 or above (preferred; required if funded by a CPO grant), NCL, or R
  • [ n/a] All of my scripts are in the diagnostics/[POD short name] subdirectory, and include a main_driver script, template html, and settings.jsonc file
  • [ n/a] I have made corresponding changes to the documentation in the POD's doc/ subdirectory
  • [ n/a] I have requested that the framework developers add packages required by my POD to the python3, NCL, or R environment yaml file if necessary, and my environment builds with conda_env_setup.sh
  • [n/a ] I have added any necessary data to input_data/obs_data/[pod short name] and/or input_data/model/[pod short name]
  • [ n/a] My code is portable; it uses MDTF environment variables, and does not contain hard-coded file or directory paths
  • [ n/a] I have provided the code to generate digested data files from raw data files
  • [n/a ] Each digested data file generated by the script contains numerical data (no figures), and is 3 GB or less in size
  • [ n/a] I have included copies of the figures generated by the POD in the pull request
  • [ n/a] The repository contains no extra test scripts or data files

@wrongkindofdoctor wrongkindofdoctor self-assigned this Jan 10, 2025
@wrongkindofdoctor wrongkindofdoctor added bug Something isn't working tool Scripts or features that assist with data or code management that are not part of the framework src data catalogs Issues related to intake esm data catalogs labels Jan 10, 2025
@wrongkindofdoctor wrongkindofdoctor merged commit 38065e8 into NOAA-GFDL:main Jan 10, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working data catalogs Issues related to intake esm data catalogs tool Scripts or features that assist with data or code management that are not part of the framework src
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants