Dsc/psy2pras cleanup #25
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephmckinsey
requested changes
Nov 18, 2024
| PSY.set_prime_mover_type!(temp_lumped_wind_gen, PSY.PrimeMovers.WT) | ||
| ext = PSY.get_ext(temp_lumped_wind_gen) | ||
| ext["region_gen_ts"] = | ||
| round.( |
There was a problem hiding this comment.
We should be able to turn this rounding procedure into a proper function.
| PSY.set_rating!(temp_lumped_wind_gen, maximum(ext["region_gen_ts"])) | ||
| PSY.add_component!(sys, temp_lumped_wind_gen) | ||
| for comp in wind_gs | ||
| PSY.remove_component!(sys, comp) |
There was a problem hiding this comment.
Why are we removing this component? Can't we just create the appropriate generator from the new lumped one without having to add it to the system?
| @@ -891,7 +852,7 @@ function generate_pras_system( | |||
|
|
|||
| @info "The Sienna/Data PowerSystems System is being de-serialized from the System JSON ..." | |||
| sys = try | |||
| PSY.System(sys_location; time_series_read_only=true, runchecks=false) | |||
| PSY.System(sys_location; runchecks=false) | |||
There was a problem hiding this comment.
Why was this necessary?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the tests pass locally but we might have to discuss including a test which cpatures the failure of luming logic (we can discuss more after you review this)